New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the remoteAddr in the session authhash cache, so that a chang… #2264

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@connortechnology
Copy link
Member

connortechnology commented Oct 18, 2018

…e of ip won't allow the same useless auth hash.

If your remote ip changes, but your session id cookie doesn't, we won't recalculate the auth hash.
This fixes that by including the remote ip in the key into the session. Thus a new auth hash will be generated on ip change.

Include the remoteAddr in the session authhash cache, so that a chang…
…e of ip won't allow the same useless auth hash.
@pliablepixels

This comment has been minimized.

Copy link
Contributor

pliablepixels commented Oct 18, 2018

Confirmed - this fixes the issue

@connortechnology connortechnology merged commit 17a5519 into ZoneMinder:master Oct 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment