closes #998

xlwings · Nov 29, 2018 · f01d1d3 · f01d1d3
1 parent bc20d60
commit f01d1d3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/xlwings/tests/udfs/async_tests.xlsm b/xlwings/tests/udfs/async_tests.xlsm
diff --git a/xlwings/tests/udfs/dynamic_array_tests.xlsm b/xlwings/tests/udfs/dynamic_array_tests.xlsm
diff --git a/xlwings/tests/udfs/udf_tests.py b/xlwings/tests/udfs/udf_tests.py
@@ -716,5 +716,10 @@ def method_signature_with_more_than_1024_characters(
     return 'splitted signature'
 
 
+@xw.sub
+def mysub(x):
+    wb = xw.Book.caller()
+    wb.sheets['Sub'].range('A3').value = x
+
 if __name__ == "__main__":
     xw.serve()
diff --git a/xlwings/tests/udfs/udf_tests.xlsm b/xlwings/tests/udfs/udf_tests.xlsm
diff --git a/xlwings/udfs.py b/xlwings/udfs.py
@@ -7,7 +7,7 @@
 from importlib import import_module
 from threading import Thread
 
-from win32com.client import Dispatch
+from win32com.client import Dispatch, CDispatch
 
 from . import conversion, xlplatform, Range, apps, PY3
 from .utils import VBAWriter
@@ -241,7 +241,7 @@ def call_udf(module_name, func_name, args, this_workbook=None, caller=None):
 
     module = get_udf_module(module_name)
     func = getattr(module, func_name)
-    if caller:
+    if caller and isinstance(caller, CDispatch):  # currently, cache is only used if caller is Range
         xw_caller = Range(impl=xlplatform.Range(xl=caller))
         cache_key = (func.__name__ + str(args) + str(xw_caller.sheet.book.app.pid) +
                      xw_caller.sheet.book.name + xw_caller.sheet.name + xw_caller.address.split(':')[0])