Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOOK_CALLER missing from xlwings/_xlmac.py #1035

Closed
christiankissig opened this Issue Feb 14, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@christiankissig
Copy link

christiankissig commented Feb 14, 2019

OS (e.g. Windows 10 or macOS Sierra)

MacOS High Sierra 10.13.6

Versions of xlwings, Excel and Python (e.g. 0.11.8, Office 365, Python 3.7)

$ pip show xlwings
Name: xlwings
Version: 0.15.2

Describe your issue (incl. Traceback!)

Traceback (most recent call last):

  File "<string>", line 1, in <module>

  File "/Users/kissig/myproject/myproject.py", line 5, in hello_xlwings

    wb = xw.Book.caller()

  File "/usr/local/lib/python3.7/site-packages/xlwings/main.py", line 567, in caller

    elif xlplatform.BOOK_CALLER:

AttributeError: module 'xlwings._xlmac' has no attribute 'BOOK_CALLER'

Include a minimal code sample to reproduce the issue (and attach a sample workbook if required!)

xlwings quickstart myproject

BOOK_CALLER is missing from https://github.com/ZoomerAnalytics/xlwings/blob/master/xlwings/_xlmac.py . It's present in https://github.com/ZoomerAnalytics/xlwings/blob/master/xlwings/_xlwindows.py .

@fzumstein fzumstein added the bug label Feb 14, 2019

@fzumstein

This comment has been minimized.

Copy link
Member

fzumstein commented Feb 14, 2019

this is a regression with 0.15.2, thanks for reporting. I'll try to release a fix asap. in the meantime please downgrade to 0.15.1

@fzumstein fzumstein added this to the 0.15.3 milestone Feb 14, 2019

@fzumstein fzumstein added the macOS label Feb 14, 2019

@christiankissig

This comment has been minimized.

Copy link
Author

christiankissig commented Feb 14, 2019

Thanks Felix! Btw I'm seeing the same issue with all xlwings versions at least back to 0.14.0 - installed with pip.

@fzumstein

This comment has been minimized.

Copy link
Member

fzumstein commented Feb 14, 2019

that's unexpected though - you do have the addin version and python version aligned, do you? anyways, will look into it.

@fzumstein

This comment has been minimized.

Copy link
Member

fzumstein commented Feb 23, 2019

Just checked it out, it's definitely a regression in 0.15.2, my guess is that something went wrong when you downgraded to 0.15.1. I'll try to fix this weekend.

fzumstein added a commit that referenced this issue Feb 23, 2019

fzumstein added a commit that referenced this issue Feb 23, 2019

@fzumstein fzumstein closed this in c8f0aa4 Feb 23, 2019

fzumstein added a commit that referenced this issue Feb 23, 2019

Merge pull request #1040 from ZoomerAnalytics/xlwings-1035-book-calle…
…r-mac

fix refactored args on Mac, closes #1035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.