New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template: issue if path to python PYTHON_WIN starts with a lowercap letter (e.g. "c:\" instead of "C:\") #234

Closed
sdementen opened this Issue Sep 27, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@sdementen
Contributor

sdementen commented Sep 27, 2015

In the excel template, if one uses in the PYTHON_WIN a path starting with lowercap the DriveCommand variable is not set proprerly.
The [A-Z] range should be extended to [A-Za-z] in code below in ExecuteWindows

If Left$(PYTHON_WIN, 2) Like "[A-Z]:" Then
    ' If Python is installed on a mapped or local drive, change to drive, then cd to path
    DriveCommand = Left$(PYTHON_WIN, 2) & " & cd " & PYTHON_WIN & " & "

I can do a pull request by not sure if the diff on the excel template will make any sense.

@fzumstein fzumstein added the bug label Sep 27, 2015

@fzumstein fzumstein added this to the v0.4.1 milestone Sep 27, 2015

@fzumstein

This comment has been minimized.

Member

fzumstein commented Sep 27, 2015

Oooh I totally forgot to update the template! This has already been fixed her: #214 so just take the xlwings.bas file from the installation directory and replace it manually.... but I am about to make a new release today so will fix that!

@fzumstein fzumstein changed the title from issue if path to python PYTHON_WIN starts with a lowercap letter (e.g. "c:\" instead of "C:\") to Update template: issue if path to python PYTHON_WIN starts with a lowercap letter (e.g. "c:\" instead of "C:\") Sep 27, 2015

@fzumstein fzumstein closed this in ba25b95 Sep 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment