New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xw.Book() and xw.books.open() raise different error if file does not exist #540

Closed
fzumstein opened this Issue Aug 5, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@fzumstein
Member

fzumstein commented Aug 5, 2016

should be aligned

@fzumstein fzumstein added this to the short list milestone Aug 5, 2016

@ghost

This comment has been minimized.

ghost commented Oct 14, 2016

xw.books.open("Test.xlsx") should open up this file if it isn't open. Right now just returning AttributeError.
xw.Book("Test.xlsx") opens up Test.xlsx as expected.

@ghost

This comment has been minimized.

ghost commented Oct 14, 2016

I cloned this to my Git and rand the unit tests. They work fine and now so does xw.books.open("Test.xlsx"). Seems something was causing my previous calls to xl.books.open() to attempt to reference a None object.

@fzumstein

This comment has been minimized.

Member

fzumstein commented Oct 15, 2016

xw.books is the collection of the active app. If there's no Excel instance running, i.e. there's no app, it will not work. xw.Book is a convenience class that takes care of instantiating a new app if there isn't one yet.

@fzumstein fzumstein modified the milestones: v0.10.1, short list Oct 18, 2016

fzumstein added a commit that referenced this issue Oct 18, 2016

Harmonize 'file does not exist' error closes #540 (#570)
* initial commit on my fork

* test commit

* chenged gitignore

* linked eceptions for Book() and Books()

* fix for issue 540

coordinated exceptions accross calls to xw.Book and .books() methods.
Added one unit test to each unit test suite (look for _bad_open)

* deleted project files

* test

@fzumstein fzumstein added bug and removed enhancement labels Oct 18, 2016

@fzumstein fzumstein closed this Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment