New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config from (optional) xlwings.conf in workbook's directory #772

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
2 participants
@codeape2

codeape2 commented Nov 1, 2017

Current config system is:

  • values in xlwings.conf sheet can override ...
  • ... values from the user's ~/xlwings.conf file

The code in the PR modifies the config system:

  • values in xlwings.conf sheet can override...
  • ... values from xlwings.conf file in the workbook's folder can override ...
  • ... values from the user's ~/xlwings.conf file

I have a scenario where a xlwings-powered workbook should be deployed to a Citrix environment. This change makes it easier to deploy a package w/ the workbook on the environment. With this change, the automated deployment system can simply create a text file in the workbook's directory.

(contrast without the change: Either make sure all users have ~/xlwings.conf file in their home directories, or use COM automation to modify contents of the workbook's xlwings.conf)

@fzumstein

This comment has been minimized.

Member

fzumstein commented Nov 6, 2017

Looks great, will try to merge/release soon, thanks!

@codeape2

This comment has been minimized.

codeape2 commented Dec 13, 2017

Now that the add-in is version controlled using xltrail, how should PRs be submitted for VBA code? Should I create a PR with xlwings.xlam ?

And how abt. the _standalone.xlsm workbooks, are they handled by the build process?

@fzumstein

This comment has been minimized.

Member

fzumstein commented Dec 13, 2017

We didnt' have any automatic merging in place pre xltrail neither, I will need to do some manual work. So your PR is still fine, apologies for the slowliness in merging.

the standalone files are built by https://github.com/ZoomerAnalytics/xlwings/blob/master/scripts/build_standalone_files.py so these are fine.

@fzumstein fzumstein added this to the v0.11.5 milestone Jan 2, 2018

fzumstein added a commit that referenced this pull request Jan 6, 2018

@fzumstein fzumstein merged commit e286c99 into ZoomerAnalytics:master Jan 6, 2018

@codeape2 codeape2 deleted the codeape2:threelevel_config branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment