New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross-platform development of UDFs #780

Merged
merged 3 commits into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@rbubley
Contributor

rbubley commented Nov 20, 2017

Currently, if you have a file that contains UDFs destined for windows, with a decorator like: @xw.arg('foo', doc='bar'), this would generate an error on a non-windows platform:

TypeError: arg() got an unexpected keyword argument 'doc'

Enable cross-platform development of UDFs
Ignore args and kwargs given to @xw.arg if not on Windows
@fzumstein

This comment has been minimized.

Member

fzumstein commented Nov 21, 2017

@rbubley

This comment has been minimized.

Contributor

rbubley commented Nov 21, 2017

Hi @fzumstein, the existing code doesn't work if arguments are passed to these decorators. The PR amends the lines you indicated to swallow decorator arguments on non-windows machines.

@fzumstein

This comment has been minimized.

Member

fzumstein commented Nov 21, 2017

sorry that was too quick! could you please do the same for func and sub, then I can merge, thanks!

@fzumstein fzumstein added this to the v0.11.5 milestone Nov 22, 2017

@fzumstein fzumstein merged commit 5e964c4 into ZoomerAnalytics:master Nov 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment