New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise exception in case of jagged arrays #942

Merged
merged 1 commit into from Oct 21, 2018

Conversation

Projects
None yet
2 participants
@fzumstein
Member

fzumstein commented Oct 2, 2018

No description provided.

@Colin-b

Doesn't it introduce a performance drop on huge volume of data ? Also in the same situation, wouldn't it be faster to compute the length of the first row only once (or is it a fast enough computation?)

Candid questions here

@fzumstein fzumstein force-pushed the jagged-array-check branch 3 times, most recently from f49bc59 to ee239c7 Oct 2, 2018

@fzumstein fzumstein force-pushed the jagged-array-check branch from ee239c7 to 7b6986e Oct 21, 2018

@fzumstein fzumstein added this to the v0.13.0 milestone Oct 21, 2018

@fzumstein fzumstein merged commit 6970932 into master Oct 21, 2018

1 check passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
@fzumstein

This comment has been minimized.

Member

fzumstein commented Oct 21, 2018

I'd expect most users to work with numpy/pandas when using huge data. If it turns out to be an issue we can always roll back.

@fzumstein fzumstein deleted the jagged-array-check branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment