Fix accessibility tests 👨🏻🔧 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 24, 2019 16:48
The latest patch of this library throws unexpected accesssibility violations around duplicated ID attributes on components. See this issue for more context: NickColley/jest-axe#56
We were skipping some tests are they were throwing unexpected errors related to accessibility. See this issue for more context: #1 After downgrading `jest-axe` they behave correctly. We'll open an issue once the correct patch for `jest-axe` comes in.
ubbe-xyz
force-pushed
the
test/1-fix-accessibility-tests
branch
from
b75ee10
to
e70b3c8
Compare
|
Had a |
After rebasing against `master` we lost some changes. Bringing them back.
|
I'm getting this error 🤷♂ |
|
@poteirard ah I see many of the atoms are written in this fashion for some reason: const SAtom = styled.div`
/* ... */
`
const Atom = props => <SAtom {...props} />;
export default Atom;Doesn't look too good as it seems it's done to workaround the Styleguidst warning above? 🤔 I'll revert the changes of the file as they're out of the scope of this PR, but maybe we can open an issue to dive deep into this warning? |
added 2 commits
May 24, 2019 17:18
Closed
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems that the latest patch of
jest-axethrows unexpected errors around accessibility violations.See this issue for more context on why.
I pinned
jest-axeto3.1.0and brought back the tests we were skipping.I'll open an issue to bring back
jest-axeto^3.*.*once they patch their patch 👍🏻 🚑Issue
Fixes #1