Skip to content

Commit

Permalink
added setgroups before setuid darkk#50
Browse files Browse the repository at this point in the history
  • Loading branch information
Zrubi committed Jun 14, 2018
1 parent 918ab10 commit 93a04de
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions base.c
Expand Up @@ -468,6 +468,11 @@ static int base_init()
}

if (instance.user) {
/* This executable is calling setuid and setgid without setgroups or initgroups.
* There is a high probability this mean it didn't relinquish all groups, and
* this would be a potential security issue to be fixed. Seek POS36-C on the web
* for details about the problem. */
setgroups(0, NULL);
if (setuid(uid) < 0) {
log_errno(LOG_ERR, "setuid(%i)", uid);
goto fail;
Expand Down

0 comments on commit 93a04de

Please sign in to comment.