Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default binary to auto-detect #2190

Closed
wants to merge 1 commit into from
Closed

fix: set default binary to auto-detect #2190

wants to merge 1 commit into from

Conversation

antonpetrov145
Copy link

@antonpetrov145 antonpetrov145 commented Jun 2, 2024 •
edited
Loading

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • Additional info: this PR is because issue Unable to run moviepy on debian 10 #2189, to fix this I did set the default value of FFMPEG_BINARY to auto-detect and remade the test

@studioj
Copy link

studioj commented Jun 3, 2024

this is also happening on windows. A temporary fix would be to lock

imageio-ffmpeg<0.5

@antonpetrov145 antonpetrov145 mentioned this pull request Jun 8, 2024
Open
2 tasks
@antonpetrov145
Copy link
Author

Closing as per discussion in referred issue.

@keikoro
Copy link
Collaborator

keikoro commented Jun 11, 2024

Link to the comment/thread in question, just for reference: #2189 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonpetrov145 @studioj @keikoro