Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ffmpeg additional params writing videoclip audio #970

Closed
wants to merge 2 commits into from
Closed

Use ffmpeg additional params writing videoclip audio #970

wants to merge 2 commits into from

Conversation

biarne-a
Copy link

@biarne-a biarne-a commented Jun 7, 2019 •
edited by mondeja

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@biarne-a biarne-a changed the title [bug-fix] Use ffmpeg additional params when writing the audio part of… Use ffmpeg additional params when writing the audio part of… Jun 7, 2019
@tburrows13 tburrows13 added feature New addition to the API i.e. a new class, method or parameter. breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog. and removed feature New addition to the API i.e. a new class, method or parameter. labels Mar 10, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 64.686% when pulling 4a3887f on biarne-a:biarne-a into 7353216 on Zulko:master.

@mondeja mondeja changed the title Use ffmpeg additional params when writing the audio part of… Use ffmpeg additional params writing videoclip audio Jan 25, 2021
@mondeja mondeja mentioned this pull request Jan 25, 2021
Open
@mondeja
Copy link
Collaborator

mondeja commented Jan 25, 2021

Closing this in favour of #1493

@mondeja mondeja closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaitan mgaitan mgaitan left review comments

@mondeja mondeja mondeja left review comments

Assignees
No one assigned
Labels
breaking-change Must not merge without proper approval. Requires full documentation (own section) in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@biarne-a @coveralls @mondeja @mgaitan @tburrows13