This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
feat: flag delete formula #961
Merged
GuillaumeFalourd
merged 12 commits into
ZupIT:master
from
lucasdittrichzup:feature/flag-delete-formula
Jun 24, 2021
Merged
feat: flag delete formula #961
GuillaumeFalourd
merged 12 commits into
ZupIT:master
from
lucasdittrichzup:feature/flag-delete-formula
Jun 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
lucasdittrichzup
added
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
labels
Jun 10, 2021
lucasdittrichzup
requested review from
GuillaumeFalourd,
fabianofernandeszup and
maurineimirandazup
June 10, 2021 19:47
lucasdittrichzup
requested review from
brunasilvazup,
fernandobelettizup,
henriquemoraeszup,
kaduartur and
rodrigomedeirosf
as code owners
June 10, 2021 19:47
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 84.50% 84.36% -0.14%
==========================================
Files 123 123
Lines 4781 4823 +42
==========================================
+ Hits 4040 4069 +29
- Misses 481 488 +7
- Partials 260 266 +6
Continue to review full report at Codecov.
|
lucasdittrichzup
changed the title
Feature/flag delete formula
feat: flag delete formula
Jun 11, 2021
…tests Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
GuillaumeFalourd
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, well done! 👍🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
📚 documentation
Improvements or additions to documentation
🔨 improvement
Improvement in features
✔️ ready-for-review
ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding flag support to
rit delete formula
command. Some of the refactoring done as well in this PR:Close #716
How to verify it
rit delete formula --workspace=<workspace name> --formula=<rit test formula>
and check if has been deleted succesfully.rit delete formula
and check if the delete confirmation works.Changelog
Update delete formula for input flags