Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

feat: flag delete formula #961

Merged

Conversation

lucasdittrichzup
Copy link
Contributor

Description

Adding flag support to rit delete formula command. Some of the refactoring done as well in this PR:

  • Added tests to support flags and changed tests to work with a tmp directory instead of only mocks.

Close #716

How to verify it

  • Run rit delete formula --workspace=<workspace name> --formula=<rit test formula> and check if has been deleted succesfully.
  • Run rit delete formula and check if the delete confirmation works.

Changelog

Update delete formula for input flags

…folder

Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #961 (a9aab3c) into master (f1c7849) will decrease coverage by 0.13%.
The diff coverage is 85.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   84.50%   84.36%   -0.14%     
==========================================
  Files         123      123              
  Lines        4781     4823      +42     
==========================================
+ Hits         4040     4069      +29     
- Misses        481      488       +7     
- Partials      260      266       +6     
Impacted Files Coverage Δ
pkg/cmd/delete_formula.go 72.63% <85.93%> (-2.21%) ⬇️
pkg/cmd/create_formula.go 87.70% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c7849...a9aab3c. Read the comment docs.

@lucasdittrichzup lucasdittrichzup changed the title Feature/flag delete formula feat: flag delete formula Jun 11, 2021
…tests

Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
Signed-off-by: lucas.dittrich <lucas.dittrich@zup.com.br>
@lucasdittrichzup lucasdittrichzup removed the 🚧 WIP Work in Progress label Jun 24, 2021
Copy link
Contributor

@GuillaumeFalourd GuillaumeFalourd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, well done! 👍🏼

@GuillaumeFalourd GuillaumeFalourd merged commit f9dcaa6 into ZupIT:master Jun 24, 2021
@lucasdittrichzup lucasdittrichzup deleted the feature/flag-delete-formula branch July 21, 2021 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 documentation Improvements or additions to documentation 🔨 improvement Improvement in features ✔️ ready-for-review ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support flags for rit delete formula
3 participants