Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response has no CORS headers in case of error response #8

Closed
ryosms opened this Issue Jan 30, 2019 · 1 comment

Comments

2 participants
@ryosms
Copy link

ryosms commented Jan 30, 2019

EX: Get a Pixel API

If Pixel is registerd, API return 200 status with CORS headers.
But in case of error, API return without CORS headers.
Add CORS headers even in case of error response, please.

thanks.

@a-know a-know added this to Want to do in Pixela Development Jan 30, 2019

@a-know a-know moved this from Want to do to Doing in Pixela Development Feb 11, 2019

ryosms added a commit to ryosms/pixela-diary that referenced this issue Feb 11, 2019

@a-know a-know moved this from Doing to Released in Pixela Development Feb 12, 2019

@a-know

This comment has been minimized.

Copy link
Owner

a-know commented Feb 12, 2019

Done!!
Thank you for feedback! Let me know if you have any questions or concerns.

@a-know a-know closed this Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.