Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Packaging #54

Merged
merged 74 commits into from Aug 28, 2021
Merged

[WIP] Packaging #54

merged 74 commits into from Aug 28, 2021

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Mar 15, 2021

Adding:

  • versioneer for version management
  • Travis CI
  • Contributors and Contributor guidelines
  • Dependabot
  • PyPI release
  • Misc badges

@a-r-j a-r-j changed the base branch from master to graphein-api March 15, 2021 15:25
@codecov-io
Copy link

codecov-io commented Mar 21, 2021

Codecov Report

Merging #54 (0e71a56) into graphein-api (6c946d9) will increase coverage by 24.46%.
The diff coverage is 36.18%.

Impacted file tree graph

@@                Coverage Diff                @@
##           graphein-api      #54       +/-   ##
=================================================
+ Coverage         19.33%   43.79%   +24.46%     
=================================================
  Files                25       41       +16     
  Lines              1583     2379      +796     
=================================================
+ Hits                306     1042      +736     
- Misses             1277     1337       +60     
Impacted Files Coverage Δ
graphein/grn/config.py 0.00% <0.00%> (ø)
graphein/grn/edges.py 0.00% <0.00%> (ø)
graphein/grn/features/node_features.py 0.00% <0.00%> (ø)
graphein/grn/graphs.py 0.00% <0.00%> (ø)
graphein/grn/parse_regnetwork.py 0.00% <0.00%> (ø)
graphein/grn/parse_trrust.py 0.00% <0.00%> (ø)
graphein/protein/edges/intramolecular.py 22.68% <0.00%> (-13.59%) ⬇️
graphein/protein/edges/atomic.py 18.05% <14.28%> (+18.05%) ⬆️
graphein/protein/features/nodes/dssp.py 24.35% <22.03%> (+24.35%) ⬆️
graphein/protein/features/nodes/aaindex.py 40.90% <40.90%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7a688...0e71a56. Read the comment docs.

a-r-j and others added 2 commits March 21, 2021 19:24
Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.46.0 to 4.60.0.
- [Release notes](https://github.com/tqdm/tqdm/releases)
- [Commits](tqdm/tqdm@v4.46.0...v4.60.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@@ -27,7 +28,7 @@ def add_sequence_to_nodes(n, d):
# Todo mapping with bioservices to support other protein IDs?

for id in d["uniprot_ids"]:
d[f"sequence_{id}"] = u.get_fasta_sequence(id)
d[f"sequence"] = u.get_fasta_sequence(id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for f-string anymore, since no variable is being inserted?

Suggested change
d[f"sequence"] = u.get_fasta_sequence(id)
d["sequence"] = u.get_fasta_sequence(id)

"from graphein.protein.graphs import construct_graph\n",
"\n",
"g = construct_graph(config=config, pdb_code=\"3eiy\")\n",
"g = construct_graph(config=config, pdb_path=\"../examples/pdbs/3eiy.pdb\")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is incorrect.

Suggested change
"g = construct_graph(config=config, pdb_path=\"../examples/pdbs/3eiy.pdb\")"
"g = construct_graph(config=config, pdb_path=\"../graphein/examples/pdbs/3eiy.pdb\")"

Sean Aubin added 2 commits April 12, 2021 16:01
.travis.yml Outdated Show resolved Hide resolved
@Seanny123
Copy link
Contributor

For my own notes:

Currently the TravisCI tests are failing because the tests are too slow. This is surprising to me, given they aren't using many resources on my machine. This might be solved with one of the pytest plugins which run tests in parallel. Alternatively, profiling ests/protein/test_graphs.py::test_sequence_features may be helpful.

@a-r-j
Copy link
Owner Author

a-r-j commented Apr 13, 2021

For my own notes:

Currently the TravisCI tests are failing because the tests are too slow. This is surprising to me, given they aren't using many resources on my machine. This might be solved with one of the pytest plugins which run tests in parallel. Alternatively, profiling ests/protein/test_graphs.py::test_sequence_features may be helpful.

Hey @Seanny123 ! iirc this is due to the pre-trained ESM models being downloaded for use in the sequence features. Probably makes sense to remove that from tests.

a-r-j and others added 9 commits April 19, 2021 10:43
Enable 3D visualisation with Plotly
Bumps [biopandas](https://github.com/rasbt/biopandas) from 0.2.4 to 0.2.8.
- [Release notes](https://github.com/rasbt/biopandas/releases)
- [Changelog](https://github.com/rasbt/biopandas/blob/main/docs/CHANGELOG.md)
- [Commits](BioPandas/biopandas@v0.2.4...v0.2.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: Sean Aubin <seanaubin@gmail.com>
should not allow any str
plt is the matplotlib.pyplot module and isn't helfpul to return
@a-r-j a-r-j merged commit 975275f into graphein-api Aug 28, 2021
@a-r-j a-r-j deleted the packaging branch October 6, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants