-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add webdav path resolver composite #52
Conversation
@thestomprock Thanks for your updated patch. But as far as I can tell, the "old" url is still working as of nextcloud v20.0.4. |
@a-schild added auto detection of the correct path/ncVersion |
Not sure how old NC server you want to support, but all suported NC version have new dav already in place, same is since NC12, so I would not go with auto detect, but simply use newest endpoint. |
There is a bug in your code, in the test cases the resulting remote path is incorrect.
but correct would be:
Some / are encoded as hex values and there are too many / at the start+end of the path |
@thestomprock There is a problem with your pull request. I think to solve the problem, we must login to NC and then retrieve the current user ID and then use this as the username part in the url. |
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html |
Hi,
I added an WebDavPath resolver. This is because, my nextcloud instance ( 20.0.4) does not have the same default paths
as the implementation on the master branch.
I added an interface where you can composite the path calculation.
The default behavior still remains the same.
Mark