削除の N+1

Author: a01sa01to

workspaces/schema/src/models/episode.ts

@@ -18,6 +18,7 @@ export const episode = sqliteTable(
     chapter: integer('chapter').notNull(),
 
     // relations
+    authorId: text('author_id').notNull(),
     bookId: text('book_id').notNull(),
     imageId: text('image_id').notNull(),
 

workspaces/schema/src/models/episodePage.ts

@@ -16,6 +16,8 @@ export const episodePage = sqliteTable(
 
     // relations
     episodeId: text('episode_id').notNull(),
+    bookId: text('book_id').notNull(),
+    authorId: text('author_id').notNull(),
     imageId: text('image_id').notNull(),
 
     // metadata

workspaces/schema/src/models/feature.ts

@@ -13,6 +13,7 @@ export const feature = sqliteTable(
 
     // relations
     bookId: text('book_id').notNull(),
+    authorId: text('author_id').notNull(),
 
     // metadata
     createdAt: text('created_at')

workspaces/schema/src/models/ranking.ts

@@ -16,6 +16,7 @@ export const ranking = sqliteTable(
 
     // relations
     bookId: text('book_id').notNull(),
+    authorId: text('author_id').notNull(),
 
     // metadata
     createdAt: text('created_at')

workspaces/schema/src/models/relations/episodePageRelations.ts

@@ -1,10 +1,20 @@
 import { relations } from 'drizzle-orm';
 
+import { author } from '../author';
+import { book } from '../book';
 import { episode } from '../episode';
 import { episodePage } from '../episodePage';
 import { image } from '../image';
 
 export const episodePageRelations = relations(episodePage, ({ one }) => ({
+  author: one(author, {
+    fields: [episodePage.authorId],
+    references: [author.id],
+  }),
+  book: one(book, {
+    fields: [episodePage.bookId],
+    references: [book.id],
+  }),
   episode: one(episode, {
     fields: [episodePage.episodeId],
     references: [episode.id],

workspaces/schema/src/models/relations/episodeRelations.ts

@@ -1,11 +1,16 @@
 import { relations } from 'drizzle-orm';
 
+import { author } from '../author';
 import { book } from '../book';
 import { episode } from '../episode';
 import { episodePage } from '../episodePage';
 import { image } from '../image';
 
 export const episodeRelations = relations(episode, ({ many, one }) => ({
+  author: one(author, {
+    fields: [episode.authorId],
+    references: [author.id],
+  }),
   book: one(book, {
     fields: [episode.bookId],
     references: [book.id],

workspaces/schema/src/models/relations/featureRelations.ts

@@ -1,9 +1,14 @@
 import { relations } from 'drizzle-orm';
 
+import { author } from '../author';
 import { book } from '../book';
 import { feature } from '../feature';
 
 export const featureRelations = relations(feature, ({ one }) => ({
+  author: one(author, {
+    fields: [feature.authorId],
+    references: [author.id],
+  }),
   book: one(book, {
     fields: [feature.bookId],
     references: [book.id],

workspaces/schema/src/models/relations/rankingRelations.ts

@@ -1,9 +1,14 @@
 import { relations } from 'drizzle-orm';
 
+import { author } from '../author';
 import { book } from '../book';
 import { ranking } from '../ranking';
 
 export const rankingRelations = relations(ranking, ({ one }) => ({
+  author: one(author, {
+    fields: [ranking.authorId],
+    references: [author.id],
+  }),
   book: one(book, {
     fields: [ranking.bookId],
     references: [book.id],

workspaces/server/src/database/drizzle.ts

@@ -19,6 +19,19 @@ export function initializeDatabase() {
   sqlite = new Database(DATABASE_PATH, {
     readonly: false,
   });
+  sqlite.exec('ALTER TABLE episode ADD COLUMN author_id TEXT NOT NULL DEFAULT "0";');
+  sqlite.exec('UPDATE episode SET author_id = (SELECT author_id FROM book WHERE book_id = episode.book_id);');
+  sqlite.exec('ALTER TABLE episode_page ADD COLUMN author_id TEXT NOT NULL DEFAULT "0";');
+  sqlite.exec('ALTER TABLE episode_page ADD COLUMN book_id TEXT NOT NULL DEFAULT "0";');
+  sqlite.exec('UPDATE episode_page SET author_id = (SELECT author_id FROM book WHERE book_id = episode_page.book_id);');
+  sqlite.exec(
+    'UPDATE episode_page SET book_id = (SELECT book_id FROM episode WHERE episode_id = episode_page.episode_id);',
+  );
+  sqlite.exec('ALTER TABLE feature ADD COLUMN author_id TEXT NOT NULL DEFAULT "0";');
+  sqlite.exec('UPDATE feature SET author_id = (SELECT author_id FROM book WHERE book_id = feature.book_id);');
+  sqlite.exec('ALTER TABLE ranking ADD COLUMN author_id TEXT NOT NULL DEFAULT "0";');
+  sqlite.exec('UPDATE ranking SET author_id = (SELECT author_id FROM book WHERE book_id = ranking.book_id);');
+
   database = drizzle(sqlite, { schema });
 }
 

workspaces/server/src/repositories/author.ts

@@ -205,27 +205,11 @@ class AuthorRepository implements AuthorRepositoryInterface {
     try {
       await getDatabase().transaction(async (tx) => {
         await tx.delete(author).where(eq(author.id, options.params.authorId)).execute();
-        const deleteBookRes = await tx
-          .delete(book)
-          .where(eq(book.authorId, options.params.authorId))
-          .returning({
-            bookId: book.id,
-          })
-          .execute();
-        for (const book of deleteBookRes) {
-          await tx.delete(feature).where(eq(feature.bookId, book.bookId)).execute();
-          await tx.delete(ranking).where(eq(ranking.bookId, book.bookId)).execute();
-          const deleteEpisodeRes = await tx
-            .delete(episode)
-            .where(eq(episode.bookId, book.bookId))
-            .returning({
-              episodeId: episode.id,
-            })
-            .execute();
-          for (const episode of deleteEpisodeRes) {
-            await tx.delete(episodePage).where(eq(episodePage.episodeId, episode.episodeId)).execute();
-          }
-        }
+        await tx.delete(book).where(eq(book.authorId, options.params.authorId)).execute();
+        await tx.delete(feature).where(eq(feature.authorId, options.params.authorId)).execute();
+        await tx.delete(ranking).where(eq(ranking.authorId, options.params.authorId)).execute();
+        await tx.delete(episode).where(eq(episode.authorId, options.params.authorId)).execute();
+        await tx.delete(episodePage).where(eq(episodePage.authorId, options.params.authorId)).execute();
       });
 
       return ok({});