Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #1

Merged
merged 1,347 commits into from Mar 5, 2019

Conversation

Projects
None yet
@a044161
Copy link
Owner

a044161 commented Mar 5, 2019

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for branch feature.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

afc163 and others added some commits Feb 2, 2019

zy410419243 and others added some commits Mar 4, 2019

@afc163

This comment has been minimized.

Copy link
Member Author

afc163 commented on 7bbeaff Mar 4, 2019

@yoyo837

This comment has been minimized.

Copy link
Contributor

yoyo837 commented on components/form/FormItem.tsx in 1fc8dd3 Mar 4, 2019

Warning: Each child in a list should have a unique "key" prop.

@yoyo837

This comment has been minimized.

Copy link
Contributor

yoyo837 commented on components/form/FormItem.tsx in 1fc8dd3 Mar 4, 2019

Warning: Each child in a list should have a unique "key" prop.

zombieJ and others added some commits Mar 4, 2019

fix form warning (ant-design#15160)
* fix form warning

* update snapshot
🐛 (Site_Icon_Display) modify background color for two tone icon item
when theme equal twoTone add calss to li tag, modify hover color from primary color to #8ecafe.

Closes #1
@yoyo837

This comment has been minimized.

Copy link
Contributor

yoyo837 commented on 42f5aea Mar 4, 2019

-> 以及

chenshuai2144 and others added some commits Mar 4, 2019

Merge pull request ant-design#15156 from ant-design/date-picker-popup
fix configProvider getPopupContainer not work with DatePicker
Merge pull request ant-design#15148 from ant-design/improve-pull-requ…
…est-template

Opitimize the pull request template
Merge pull request ant-design#15176 from ant-design/fix-collapse-extra
Fix Collapse extra node style missing
Merge pull request ant-design#15170 from Hazyzh/modify_doc_icon_bg
 (Site_Icon_Display) modify background color for two tone icon item

@a044161 a044161 merged commit 183c6df into a044161:master Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.