Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Teach the script about target architecture and kernel version #9
Some recommendations are dependent on the processor architecture and/or the kernel version. For example, the KSPP recommendations differ between x86_32 and x86_64. Additionally, option names change over time such as when
This pull request adds the ability to reason about the architecture and version when constructing the checklist. It also teaches the script about
I verified that all the example configs in
Hello @tyhicks ,
Thank you very much for this pull request! Great!
I briefly looked through the patches and I would like to discuss the approach with you before we proceed.
May I ask you to extract arch support into a separate pull request? We will work further to merge it.
Thanks again for your time!
Glad that you find it useful. I plan to use the script and these changes to audit all of the Ubuntu kernel configs and enable reasonable hardening options that aren't yet enabled.
To be honest, I expected that you'd dislike the kernel version checking. I am on the fence about its usefulness, as well. It currently doesn't add much functionality on top of what
Maybe I'll just drop the version checking now and, in the future, propose some type of external overrides file that lets me ignore the false negatives when running against a given version of an old kernel. Additionally, this would let me specify overrides for certain options that we simply can't enable in a general purpose distro kernel.
Certainly. It might not happen today but I'll get a new PR up very soon.
@a13xp0p0v I have a slightly unrelated question about the script that I'll ask here since I mentioned using this script with our Ubuntu kernel configs. What does
Nice. I want this script to serve all your needs out of the box.
Ok, I see. In other words we need some functionality for categorizing and muting script errors, right?
I face a similar task as well and currently I solve it manually:
Yes, let's create that!
I see two approaches:
What do you think?
Thank you! Take your time, we are not in a hurry.
The values in
So I use:
Thanks for your question, I think I should document that in the README.