-
Notifications
You must be signed in to change notification settings - Fork 302
perf: Improve performance and code style for proto_utils.py
#452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the proto_utils.py module by introducing performance optimizations, refining code style for better maintainability, and improving the robustness of data conversion and error handling. The changes aim to make the codebase more efficient, readable, and capable of handling new data structures, ultimately leading to a more stable and performant system.
Highlights
- Performance Optimization: Regular expression patterns are now pre-compiled using
re.compile()for improved efficiency when matching strings, reducing overhead on repeated operations. - Code Style and Maintainability: Internal calls within the
ToProtoandFromProtoclasses have been updated from direct class references (e.g.,ToProto.method()) tocls.method(), enhancing code readability and adhering to Python's object-oriented best practices for class methods. - Data Conversion Refinement: The
dict_to_structutility function was relocated and its usage withinToProto.datawas streamlined, removing an unnecessary intermediate JSON serialization step and simplifying the conversion of Python dictionaries to Protobuf Structs. - New Security Scheme Support: Added support for handling
mtls_security_schemewithin theFromProto.security_schememethod, expanding the types of security configurations that can be processed. - Enhanced Error Handling: Improved the robustness of
stream_responsemethods by adding explicit type checks and raisingValueErrorfor unsupported event types, making the system more resilient to unexpected inputs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several improvements to proto_utils.py, focusing on performance and code style. The changes include pre-compiling regular expressions, optimizing dictionary-to-protobuf Struct conversion, and consistently using cls in class methods. Additionally, it contains important bug fixes for handling stream responses and refactors some methods for better maintainability. The changes are well-aligned with the PR's goals. I have a couple of suggestions to further simplify the new dict_to_struct helper function and improve its documentation for future maintainers.
0b6eedb to
cb3c237
Compare
🤖 I have created a release *beep* *boop* --- ## [0.3.4](v0.3.3...v0.3.4) (2025-09-02) ### Features * Add `ServerCallContext` into task store operations ([#443](#443)) ([e3e5c4b](e3e5c4b)) * Add extensions support to `TaskUpdater.add_artifact` ([#436](#436)) ([598d8a1](598d8a1)) ### Bug Fixes * convert auth_required state in proto utils ([#444](#444)) ([ac12f05](ac12f05)) * handle concurrent task completion during cancellation ([#449](#449)) ([f4c9c18](f4c9c18)) * Remove logger error from init on `rest_adapter` and `jsonrpc_app` ([#439](#439)) ([9193208](9193208)) * resolve streaming endpoint deadlock by pre-consuming request body ([#426](#426)) ([4186731](4186731)) * Sync jsonrpc and rest implementation of authenticated agent card ([#441](#441)) ([9da9ecc](9da9ecc)) ### Performance Improvements * Improve performance and code style for `proto_utils.py` ([#452](#452)) ([1e4b574](1e4b574)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
clsinstead ofClassNameToProto.data()to usedict_to_struct()ToProto.update_event()andToProto.stream_response()MutualTlsSecurityScheme