Keep previous handler #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new boolean parameter, `keepPreviousHandler`. When set to true, it stores the previous handler value and calls it after calling the newly set exception handler. This allows developers to keep the previous functionality (red screen) intact, while still capturing errors (i.e. for analytics purposes).
a7ul
approved these changes
Jun 19, 2017
Owner
a7ul
left a comment
a7ul
left a comment
There was a problem hiding this comment.
Looks good to me . I think readme could be more elaborative. But I think I ll do that part. Thanks for this PR. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new boolean parameter to
setJSExceptionHandler,keepPreviousHandler. When set totrue, it stores the previous handler function and calls it after calling the newly set exception handler. This allows developers to keep the previous functionality (red screen) intact, while still capturing errors (i.e. for analytics purposes).