Skip to content

test(watcher): simplify, fix typos #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2015
Merged

test(watcher): simplify, fix typos #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions test/spec/provider/watcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,16 @@

describe('filterWatcherProvider', function() {
//helpers
function n(n) { return n; }
var stub = { fn: function(x) { return n(x) } };
var stub = { fn: function(x) { return x; } };

beforeEach(module('a8m.filter-watcher'));

it('should have 2 main functions `isMemoized` and `memozie`', inject(function(filterWatcher) {
it('should have 2 main functions `isMemoized` and `memoize`', inject(function(filterWatcher) {
expect(filterWatcher.isMemoized).toEqual(jasmine.any(Function));
expect(filterWatcher.memoize).toEqual(jasmine.any(Function));
}));

it('should called the function if it\'s not cached',
it('should call the function if it\'s not cached',
inject(function(filterWatcher) {
var spy = spyOn(stub, 'fn');
(function memoizedOnly(n) {
Expand All @@ -37,12 +36,10 @@ describe('filterWatcherProvider', function() {
})(o1);
}));

it('should get the result from cache if it\'s memoize',
it('should get the result from cache if it\'s memoized',
inject(function(filterWatcher, $rootScope) {
var scope = $rootScope.$new();
var spy = spyOn(stub, 'fn').andCallFake(function() {
return 1;
});
var spy = spyOn(stub, 'fn').andCallThrough();
function memoize(n) {
return filterWatcher.isMemoized('fName', n) ||
filterWatcher.memoize('fName', n, scope, stub.fn(n));
Expand All @@ -57,9 +54,7 @@ describe('filterWatcherProvider', function() {
it('should clear cache from scope listeners on `$destroy`',
inject(function(filterWatcher, $rootScope) {
var scope;
var spy = spyOn(stub, 'fn').andCallFake(function() {
return 1;
});
var spy = spyOn(stub, 'fn').andCallThrough();
function memoize(n) {
return filterWatcher.isMemoized('fName', n) ||
filterWatcher.memoize('fName', n, scope = $rootScope.$new(), stub.fn(n));
Expand Down