Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackoverflow generating tool tip #191

Closed
rainers opened this issue May 8, 2015 · 5 comments
Closed

Stackoverflow generating tool tip #191

rainers opened this issue May 8, 2015 · 5 comments
Labels

Comments

@rainers
Copy link
Contributor

rainers commented May 8, 2015

As reported here (http://forum.dlang.org/thread/mqpziyiopgofgphfwlgl@forum.dlang.org), generating a tool tip for test in Visual D causes a stack overflow:

module mytest;

int function(uint) TestCase;
TestCase test;

class TestClass
{
    this()
    {
        test(); // <--- hover on this
    }
}
@aBothe
Copy link
Owner

aBothe commented May 8, 2015

Not again :/

@rainers
Copy link
Contributor Author

rainers commented May 8, 2015

Still happens after the last patch, callstack looks different:

>   D_Parser.dll!D_Parser.Resolver.DTypeToCodeVisitor.GenerateCode(D_Parser.Resolver.AbstractType t = {D_Parser.Resolver.DelegateCallSymbol}, bool pretty) Line 23  C#
    D_Parser.dll!D_Parser.Resolver.AbstractType.ToString() Line 55  C#
    D_Parser.dll!D_Parser.Resolver.DTypeToCodeVisitor.VisitDelegateCallSymbol(D_Parser.Resolver.DelegateCallSymbol t) Line 78   C#
    D_Parser.dll!D_Parser.Resolver.DelegateCallSymbol.Accept(D_Parser.Resolver.IResolvedTypeVisitor vis) Line 373   C#
    D_Parser.dll!D_Parser.Resolver.DTypeToCodeVisitor.AcceptType(D_Parser.Resolver.AbstractType t = {D_Parser.Resolver.DelegateCallSymbol}) Line 47 C#
    D_Parser.dll!D_Parser.Resolver.DTypeToCodeVisitor.GenerateCode(D_Parser.Resolver.AbstractType t, bool pretty) Line 27   C#
    D_Parser.dll!D_Parser.Resolver.AbstractType.ToString() Line 55  C#

@aBothe
Copy link
Owner

aBothe commented May 8, 2015

But now it's the DTypeToCode-Visitor, not the Hashing-Visitor anymore - gonna have a look in a couple of minutes.

@aBothe aBothe closed this as completed in f3b2d56 May 8, 2015
@aBothe aBothe added the bug label May 8, 2015
aBothe pushed a commit that referenced this issue May 8, 2015
@rainers
Copy link
Contributor Author

rainers commented May 8, 2015

Thanks a lot, this fixes the crash.

The result in the tooltip test is int now, i.e. the return type. Is this expected? I was assuming it would be TestCase or int function(uint). It's TestCase test without the parentheses.

@aBothe
Copy link
Owner

aBothe commented May 8, 2015

I guess I'll make it int function(uint)

aBothe pushed a commit that referenced this issue May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants