Skip to content
Commits on Jul 6, 2011
  1. The test for #76474 should open file descriptor 0, not 1.

    The original bug report states
    
        if we try to dup STDIN in a child process by using it's file descriptor
    
    but has code to dup 1, not 0:
    
        perl -MIPC::Open3 -wle 'open3("<&1", my $out, undef, $^X)'
    
    Change the above code to "<&0" and the same bug is demonstrated, and fixed by
    the relevant change.
    
    However, trying to open descriptor 1 for input causes subtle portability
    problems, which conceal the actual bug we're attempting to test. On most
    platforms the terminal is read write, and a command tested on the command line
    actually has file descriptor 1 read/write (and probably file descriptor 0 also)
    
    When the output is being piped, for example in a test checking the output,
    descriptor 1 is (likely to be) write only. PerlIO is quite happy to *open* a
    such a numeric file descriptor for reading, and will only generate an error if
    an actual read is attempted (which this test does not). stdio (on several
    platforms tested) fails the *open* in the same scenario. Hence whether this
    *test* passed or failed depended on the IO system used, which is actually not
    what we want to test.
    
    Original test added in a0ed8b7, fix added in fb9b5b3.
    Nicholas Clark committed Jul 1, 2011
  2. @obra
  3. @rafl

    acme fixed a known POD problem in the RMG

    Update porting/known_pod_issues.date accordingly.
    rafl committed Jul 6, 2011
  4. @rafl
  5. @rafl

    Plain scalars are supposed to be literal filenames

    Anchor them accordingly.
    rafl committed Jul 6, 2011
  6. @rafl

    Fix a thinko in filtering excluded module files

    If we got a regexp ref, use it as it. Otherwise quote the string in a regexp.
    rafl committed Jul 6, 2011
  7. @acme

    Only describe the inplace mode of Porting/bump-perl-version in Portin…

    …g/release_managers_guide.pod
    acme committed Jul 6, 2011
  8. @rjbs

    disable use of nm on darwin

    Testing from 10.5 with Xcode 3 to the latest OS X works with usenm='false' but
    not always with usenm='true'
    rjbs committed Jul 6, 2011
  9. @bingos

    Update CPANPLUS to CPAN version 0.9106

      [DELTA]
    
      Changes for 0.9106      Wed Jul  6 09:53:44 2011
      ================================================
      * synchronisation with blead to remove profanity
        from the source. No other changes.
    bingos committed Jul 6, 2011
  10. In threads.xs, remove num_args from ithread_create, as it is unused.

    It has never been used - it was added unused with commit 680818c.
    Nicholas Clark committed Jul 5, 2011
  11. In cmp_version.t, show in the TAP when we are skipping a particular v…

    …ersion.
    
    The facility to skip specific versions of modules was added in
    a5a2efc. However, it gave no indication when such an exception caused
    a skip, because it generated identical TAP output to the normal pass case.
    
    Instead, we now show the diffs (as for the "not ok" TAP output), but generate
    TAP "SKIP" for the pass. This makes it clear what is happening.
    Nicholas Clark committed Jul 5, 2011
  12. In Cwd.xs, tidy the conditional code related to symlinks.

    Move the variable symlink inside the conditionally compiled code, to avoid
    on platforms which don't have symlinks about an unused variable.
    Move the pre-processor directives back to column zero - they were indented as
    part of the upgrade to PathTools 3.26_01 in c7304ea.
    Correct the indentation of some lines [always just a closing '}'], which was
    making the code harder to follow. All these lines seem to have been left
    unaltered by c7304ea, when code surrounding them changed.
    Nicholas Clark committed Jul 5, 2011
  13. @autarch

    Add section on circular refs to perlref

    autarch committed with Father Chrysostomos Jul 5, 2011
  14. perlretut: Remove references to /dul

    These modifiers are automatically selected when various
    pragmas are in effect, and their explicit use is rarely called
    for, so shouldn't be mentioned in a tutorial introduction.
    Karl Williamson committed Jul 5, 2011
  15. perlrecharclass: nits

    Karl Williamson committed Jul 5, 2011
  16. perlop: nits

    Karl Williamson committed Jul 5, 2011
  17. perllocale: de-emphasize /l

    /l outside of 'use locale' rarely makes any sense to use.
    Karl Williamson committed Jul 5, 2011
  18. podcheck.t: Add -deltas option

    This option will rarely be used, but examines stable perldelta
    files.
    Karl Williamson committed Jul 4, 2011
Commits on Jul 5, 2011
  1. @obra
  2. @obra

    Update Keith Thompson's email address in AUTHORS, add his old address…

    …es to checkAUTHORS
    obra committed Jul 5, 2011
  3. @obra

    Typo in perldelta

    Keith Thompson committed with obra Jul 5, 2011
  4. @bingos
  5. @obra
  6. @obra

    Add Steve Hay for 5.15.5

    obra committed Jul 5, 2011
  7. @iabyn

    fix segv in regcomp.c:S_join_exact()

    This function joins multiple EXACT* nodes into a single node.
    At the end, under DEBUGGING, it marks the optimised-out nodes as being
    type OPTIMIZED. However, some of the 'nodes' aren't actually nodes;
    they're random bits of string at the tail of those nodes. So you
    can't peek that the 'node's OP field to decide what type it was.
    
    Instead, just unconditionally overwrite all the slots with fake
    OPTIMIZED nodes.
    iabyn committed Jul 5, 2011
  8. Increase $XS::APItest::VERSION

    Father Chrysostomos committed Jul 4, 2011
  9. @ggoossen

    Add a test for perl_clone with CLONEf_COPY_STACKS to XS-APItest.

    CLONEf_COPY_STACKS is only used by the windows pseudo-fork.
    This test allows testing/debugging of CLONEf_COPY_STACK without needing threads or Windows.
    ggoossen committed with Father Chrysostomos Nov 6, 2010
  10. @craigberry

    Fix ?/% mix-up in Perl_vms_start_glob.

    When it sees the unixy ? as a single-character wildcard rather than
    the native %, it intended to leave it alone when the CRTL's extended
    character set processing was enabled, but it was actually checking
    for a different and unrelated feature setting (case preservation),
    meaning it would substitute % for ? in some cases where it meant
    not to.  This likely did no harm in most cases as LIB$FIND_FILE
    will honor either, but if the pattern were to be re-used in a context
    that required POSIX semantics, the ? really ought to be preserved
    and now it is.
    
    Broken in dca5a91.
    craigberry committed Jul 4, 2011
Commits on Jul 4, 2011
  1. @bingos
  2. pumpkin.pod: Add L<> around html link

    Karl Williamson committed Jul 4, 2011
  3. mktables: Add Z<> before a B<*> to pod =item

    This is to prevent some parsers from considering this to be
    a bullet item.
    Karl Williamson committed Jul 4, 2011
  4. @bingos
  5. @bingos

    [rt.cpan.org #69108] Extraneous modules listed in Module::CoreList

    There are some entries in Module::CoreList that can't be found in the
    versions suggested.
    
    After more digging, I confirmed some modules exist, but these are the
    modules I still have questions about:
    
    ================[ Devel::DProf::V ]================
    
    - Module::CoreList says it was first added in Perl 5.11.3
    
    - It's mentioned in perl5114delta.pod.
    
    - However, I can't find it in the Perl v5.11.3 source package.
    
    ================[ Simple ]================
    
    - Module::CoreList says it was first added in Perl 5.11.2
    
    - Module name not found within the Perl v5.11.2 source package (outside
      of the cpan/Module-Build/t/ directory).
    
    ================[ Devel::DProf::dprof::V ]================
    
    - Module::CoreList says it was first added in Perl 5.11.0
    
    - Module name not found in the Perl v5.11.0 source package.
      ext/Devel-DProf/dprof/V.pm exists, but it only declares package V.
    
    ================[ XSLoader::XSLoader ]================
    
    - Module::CoreList says it was first added in Perl 5.11.0
    
    - Module name not found within the Perl v5.11.0 source package.
      dist/XSLoader/XSLoader_pm.PL exists, but it doesn't declare the
      package XSLoader::XSLoader
    
    ================[ Time::Piece::Seconds ]================
    
    - Module::CoreList says it was first added in Perl 5.9.5
    
    - Module name not found in the Perl v5.9.5 source package.
      ext/Time/Piece/Seconds.pm exists, but it only declares package
      Time::Seconds.
    
    ================[ IPC::lib::IPC::Msg ]================
    
    - Module::CoreList says it was first added in Perl 5.8.9
    
    - Module name not found in the Perl v5.8.9 source package.
      ext/IPC/SysV/lib/IPC/Msg.pm exists, but it only declares packages
      IPC::Msg and IPC::Msg::stat.
    
    ================[ IPC::lib::IPC::Semaphore ]================
    
    - Module::CoreList says it was first added in Perl 5.8.9
    
    - Module name not found in the Perl v5.8.9 source package.
      ext/IPC/SysV/lib/IPC/Semaphore.pm exists, but it only defines packages
      IPC::Semaphore and IPC::Semaphore::stat.
    
    ================[ IPC::lib::IPC::SharedMem ]================
    
    - Module::CoreList says it was first added in Perl 5.8.9
    
    - Module name not found in the Perl v5.8.9 source package.
      ext/IPC/SysV/lib/IPC/SharedMem.pm exists, but it only defines packages
      IPC::SharedMem and IPC::SharedMem::stat.
    
    ================[ Module::Pluggable::lib::Devel::InnerPackage
    
    - Module::CoreList says it was first added in Perl 5.8.9
    
    - Module name not found in the Perl v5.8.9 source package.
      ext/Module/Pluggable/lib/Devel/InnerPackage.pm exists, but it only
      declares package Devel::InnerPackage.
    
    ================[ DCLsym ]================
    
    - Module::CoreList says it was first added in Perl 5.8.7
    
    - It's mentioned in perl5120delta.pod.
    
    - However, I can't find it in the Perl v5.8.7 source package.
      vms/ext/DCLsym/DCLsym.pm exists, but it only defines package
      VMS::DCLsym.
    
    ================[ Stdio ]================
    
    - Module::CoreList says it was first added in Perl 5.8.7
    
    - It's mentioned in perl5120delta.pod.
    
    - However, I can't find it in the Perl v5.8.7 source package.
      vms/ext/Stdio/Stdio.pm exists, but it only defines packages VMS::Stdio
      and VMS::stdio
    
    ================[ XSSymSet ]================
    
    - Module::CoreList says it was first added in Perl 5.8.7
    
    - It's mentioned in perl589delta.pod.
    
    - However, I can't find it in the Perl v5.8.7 source package.
      vms/ext/XSSymSet.pm exists, but it only defines package
      ExtUtils::XSSymSet.
    
    Signed-off-by: Chris 'BinGOs' Williams <chris@bingosnet.co.uk>
    Dee Newcum committed with bingos Jul 4, 2011
  6. @bingos

    Additional heuristics to catch edge-cases in corelist.pl

    Addresses [rt.cpan #69108] reported by Dee Newcum
    bingos committed Jul 4, 2011
Something went wrong with that request. Please try again.