fix: use enterprise-pull-secret and .Chart.AppVersion for image tag#31
Merged
Conversation
- Set global.imagePullSecrets to enterprise-pull-secret in values.yaml (EC v3 creates this secret; ImagePullSecretName returns wrong name) - Set image.tag to empty string so .Chart.AppVersion fallback is used - Remove global.imagePullSecrets override from helmchart.yaml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global.imagePullSecretsdefaulted toenterprise-pull-secretinvalues.yaml— this is the secret EC v3 creates;ImagePullSecretNamewas returninggameshelf-registrywhich doesn't existimage.tagchanged fromlatestto""so the| default .Chart.AppVersionfallback in the deployment template actually kicks inglobal.imagePullSecretsoverride fromhelmchart.yamlsince it's now correctly set invalues.yamlTest plan
latest)ImagePullBackOffshould be resolved