Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong warmup in perfomance test #76

Closed
dimzon opened this issue Apr 7, 2014 · 2 comments
Closed

wrong warmup in perfomance test #76

dimzon opened this issue Apr 7, 2014 · 2 comments

Comments

@dimzon
Copy link
Contributor

dimzon commented Apr 7, 2014

AFAIK Oracle HotSpot can unload JIT-generated code since it become "cold". You must warmup each method just before time measurement.

@aldenquimby
Copy link
Contributor

@dimzon so where do you think the warmup needs to happen, here, or here, or maybe somewhere else?

@dimzon
Copy link
Contributor Author

dimzon commented Apr 7, 2014

seems like the second position (l37-l38) is proper...
at least JMH do warmup such way

2014-04-07 6:10 GMT+04:00 Alden Quimby notifications@github.com:

@dimzon https://github.com/dimzon so where do you think the warmup
needs to happen, herehttps://github.com/aaberg/sql2o/blob/master/core/src/test/java/org/sql2o/performance/PerformanceTestList.java#L23or
herehttps://github.com/aaberg/sql2o/blob/master/core/src/test/java/org/sql2o/performance/PerformanceTestList.java#L37-L38or maybe somewhere else?

Reply to this email directly or view it on GitHubhttps://github.com//issues/76#issuecomment-39691088
.

@aaberg aaberg modified the milestones: 1.4.1, 1.5.0 Apr 7, 2014
@aaberg aaberg modified the milestones: 2.0, 1.5.0 Apr 22, 2014
@aaberg aaberg closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants