Add option to allow cycles that include an asynchronous dependency#37
Merged
Conversation
aackerman
reviewed
Apr 26, 2018
| this.options = extend({ | ||
| exclude: new RegExp('$^'), | ||
| failOnError: false, | ||
| allowAsyncCycles: true, |
Owner
There was a problem hiding this comment.
I think the default should be false and consumers of this plugin can opt into ignoring these because they are in fact circular.
Contributor
Author
There was a problem hiding this comment.
Sure, I've changed it to false by default.
Owner
There was a problem hiding this comment.
Thanks I'll get this into a 5.1 version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this plugin in conjunction with babel-plugin-universal-import and react-universal-component, warnings are generated for import cycles even if one of the imports in the cycle is an asynchronous
import()promise. This happens because of therequire.resolveWeakused by babel-plugin-universal-import - it generates a dependency on the module in webpack (with theweak) flag set.I've confirmed here that even on the server when
import()promises do not create separate chunks, the actual execution of the imported module is still asynchronous in the sense that it occurs after the module importing it has finished executing.So this flag should prevent generating warnings where there is no risk that imports will be undefined as a result of import cycles.