Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] `{pluginName}PluginMarkerMaven` publication is not properly configured #167

Open
tlinkowski opened this issue Aug 10, 2019 · 1 comment

Comments

@tlinkowski
Copy link
Contributor

commented Aug 10, 2019

This continues our discussion from #96 (comment).

As far as I understand the code, {pluginName}PluginMarkerMaven is not configured by your plugins, i.e. PublishingUtils.configurePom is not called for it (it's called only for pluginMaven):

private void updatePublication(Project project) {
ProjectConfigurationExtension effectiveConfig = resolveEffectiveConfig(project)
project.publishing {
publications {
pluginMaven(MavenPublication) {
PublishingUtils.configurePom(pom, effectiveConfig, effectiveConfig.publishing.pom)
}
}
}
String pluginName = effectiveConfig.plugin.pluginName
PublishingUtils.configureSigning(effectiveConfig, project, 'pluginMaven', pluginName + 'PluginMarkerMaven')
}

I worked around this by calling it on my own 🙂

@tlinkowski

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

This is more complicated than I initially thought. After all, I had to remove PluginPlugin altogether because it caused my javadoc artifact to break (see tlinkowski/tlinkowski-superpom#52).

aalmiray added a commit that referenced this issue Aug 29, 2019

@aalmiray aalmiray self-assigned this Aug 29, 2019

@aalmiray aalmiray added the bug label Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.