Jim Jones aantix

aantix commented on pull request rails/turbolinks#468
Jim Jones

Fantastic @kristianpd

aantix commented on pull request aantix/turkee#31
Jim Jones

I see that you closed this; anything that could be wrapped up into a PR that I could merge in?

aantix commented on issue rails/turbolinks#448
Jim Jones

Great considerations @kristianpd. 1) For the initial proof of concept, I was going to just render a div. Comment nodes look much more promising an…

aantix commented on issue rails/turbolinks#448
Jim Jones

I've been following the conversation and have an alternative idea: there's parity between the view's cached fragments and the sections that need to…

aantix commented on pull request rails/rails#17175
Jim Jones

The secrets.yml approach feels a bit strange just because you're specifying the key name twice (once for the secrets.yml entry and once for the ENV…

aantix commented on pull request rails/rails#18618
Jim Jones

@simi For the separation of logic and data, dynamically apply the partial/template source meta data (source_info, partial_infos) to the body attrib…

aantix commented on pull request rails/rails#17175
Jim Jones

Rebased.

Jim Jones
aantix opened pull request rails/rails#18618
Jim Jones
Better Client Side Debugging for Javascript Server Responses
10 commits with 266 additions and 12 deletions
Jim Jones
  • Jim Jones 40684c9
    Fixed issue with calculating inital error line offset.
Jim Jones
  • Jim Jones fe60bcf
    Additional testing surrounding partial line match
Jim Jones
Jim Jones
  • Jim Jones 9c44887
    The correct source is now being reported along with the problematic j…
Jim Jones
  • Jim Jones 770fe27
    WIP: Looking at outputing error line.
Jim Jones
  • Jim Jones dd4a895
    Full partial paths now output
Jim Jones
  • Jim Jones d868c0a
    Line number source mappings now correct.
aantix commented on pull request aantix/turkee#30
Jim Jones

Could this be generalized in a way to form a PR?

aantix commented on issue aantix/turkee#28
Jim Jones

Are you still interested in creating a pull request for this?