-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for string_view #55
Comments
Hi :) I've looked at it briefly, and it seems like a good thing to add. I haven't had time to properly do it, though. |
One minor annoyance is it will probably need conditional compilation, based on compiler version and an override macro to force the overloads to be enabled for when the version detection does the wrong thing. |
Yes, also because some compiler versions support only <experimental/string_view> and newer ones have <string_view> The code below worked for me
|
Thanks for that. I won't have the time to integrate it in the immediate future (because of all that conditional compilation testing that would be needed). If you'd like to give it a try, you're welcome to open a PR and test in the Better Enums CI setup. I think it might need to be updated to use some more recent compilers in its build rows. I'm not sure what to do about |
I am also interested in this feature. I think support for |
Thanks. Not to my knowledge. |
Hi
Have you considered adding support for string_view for the _from_string methods?
It doesn't convert to char * so _names_match, _from_string and _from_string_loop would need to be overloaded.
The text was updated successfully, but these errors were encountered: