New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuckleScript 8.0.0 breaks listToArray / Promise.all #56
Comments
The listToArray and arrayToList seems to be interesting that we can absorb it in upstream |
Why are these functions in this library? Isn't it better to use |
Yes, I will switch the library to the Belt functions and do a release. I don't immediately recall why I added these implementations. |
The fixed version is now in npm as reason-promise@1.1.0. Thanks @cknitt for the report! |
Thanks a lot @aantron! 🎉 |
The internal representation of lists changed in BuckleScript 8.0.0. Lists are now encoded as
{hd, tl}
, not as nested arrays anymore.This breaks the functions
listToArray
andarrayToList
and thereby all functions relying on them (Promise.all
,Promise.race
).The text was updated successfully, but these errors were encountered: