Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab.com login #204

Merged
merged 1 commit into from Nov 21, 2020
Merged

Add gitlab.com login #204

merged 1 commit into from Nov 21, 2020

Conversation

nolith
Copy link
Contributor

@nolith nolith commented Nov 21, 2020

Hello 馃憢

This PR adds GitLab.com login support.

A new application can be generated from https://gitlab.com/-/profile/applications, it requires to be set as "confidential" and the "api" scope.

oauth app screenshot

@aaronpk aaronpk closed this Nov 21, 2020
@aaronpk aaronpk deleted the branch aaronpk:main November 21, 2020 17:33
@aaronpk aaronpk reopened this Nov 21, 2020
@aaronpk aaronpk changed the base branch from master to main November 21, 2020 17:34
@aaronpk aaronpk merged commit dee9ef5 into aaronpk:main Nov 21, 2020
@aaronpk
Copy link
Owner

aaronpk commented Nov 21, 2020

This is live on indieauth.com now! Thanks!

@nolith nolith deleted the gitlab branch November 22, 2020 09:03
@nolith
Copy link
Contributor Author

nolith commented Nov 22, 2020

Thank you @aaronpk 馃帀

I鈥檒l take a look to see if we can scale down the scope to read_user instead of api. I can鈥檛 see why we need full read/write API access.

Tested now to access quill, it works like a charm!

(Originally published at: https://l0g.in/59o98T)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants