New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing author info on some mf2 feeds #79

Closed
aaronpk opened this Issue Nov 9, 2018 · 4 comments

Comments

1 participant
@aaronpk
Owner

aaronpk commented Nov 9, 2018

I've encountered several feeds now that are missing authorship information. Before I go and ask them to change their markup, I thought it would be useful to see if there is a commonality that I could instead look for.

@aaronpk

This comment has been minimized.

Owner

aaronpk commented Nov 9, 2018

Here are the mf2 patterns on each site

https://gregorlove.com/

https://martymcgui.re/posts/

  • h-feed
    • list of h-entrys with author h-card, but missing a URL

https://adactio.com/

  • h-card at the top, contains url=https://adactio.com/
  • list of h-entrys as siblings of the h-card, no author info on the h-entrys

https://waterpigs.co.uk/

  • h-feed, with author h-card
    • list of h-entrys, no author property
@aaronpk

This comment has been minimized.

Owner

aaronpk commented Nov 9, 2018

Marty's site is not actually an XRay issue, it's a problem with the template in Monocle. Fixed in this commit

@aaronpk

This comment has been minimized.

Owner

aaronpk commented Nov 9, 2018

Decided not to try to parse the gregorlove.com example since it appears to be a mistake

@aaronpk aaronpk closed this in 8043ba5 Nov 9, 2018

@aaronpk

This comment has been minimized.

Owner

aaronpk commented Nov 9, 2018

The commit above handles both the adactio.com and waterpigs.co.uk cases now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment