Persist node version choice on Mac/Linux#86
Merged
aaronpowell merged 4 commits intoaaronpowell:masterfrom May 25, 2020
Merged
Conversation
Contributor
Author
|
Not sure why tests don't pass... I'll need to try with Windows maybe. |
Owner
|
sigh Looks like something has changed in Travis since last set of build runs. Maybe we should move to GitHub actions 😜 |
Owner
|
@felixfbecker are you able to run the tests locally on a mac? I can try Windows next week. |
Contributor
Author
|
Any progress? |
Fixed default node detection to ignore package.json without version if a default one can be found
Owner
|
And released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Implementation:
-Persist, the version is written to adefaultfile (similar to.nvmrc) in thevsfolder where the node binaries are downloaded,User,Machine) a call toSet-NodeVersion(without arguments) is appended to the appropriateprofile.ps1.Set-NodeVersionwhen called without version parameter will fallback to the version written in thedefaultfile.Notes:
nvm-shfunctions (storing the version in adefaultfile and setting the path when the user profile scripts is executed),Machineconfiguration as it requires escalation: