Add semicolon to style data for safety #62

Merged
merged 1 commit into from Nov 19, 2012

Projects

None yet

2 participants

@adhiraj
Contributor
adhiraj commented Nov 16, 2012

If the style data does not contain a semicolon, the loop removing @import
statements will run infinitely, because the search for ';' returns -1, which
with a +1 becomes 0, and appends the data variable to itself. Making sure the
data variable has at least one semicolon fixes this problem.

@adhiraj adhiraj Add semicolon to style data for safety
If the style data does not contain a semicolon, the loop removing @import
statements will run infinitely, because the search for ';' returns -1, which
with a +1 becomes 0, and appends the data variable to itself. Making sure the
data variable has at least one semicolon fixes this problem.
65a540b
Owner
aaronsw commented Nov 19, 2012

Been getting a ton of pull requests lately. Is there some reason everyone is using this now?

Owner
aaronsw commented Nov 19, 2012

Can you add a test case for this?

@aaronsw aaronsw merged commit c654527 into aaronsw:master Nov 19, 2012

1 check passed

default The Travis build passed
Details
@adhiraj adhiraj added a commit to adhiraj/html2text that referenced this pull request Nov 27, 2012
@adhiraj adhiraj Added testcase for pull request #62: @import css statements not termi…
…nated by ; should be handled correctly
0d41bc9
@pombredanne pombredanne pushed a commit to pombredanne/html2text that referenced this pull request Oct 10, 2015
@Alir3z4 Alir3z4 Better way of getting version number from module
Fixes #62
0d32483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment