Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix missing fonts by falling back to Menlo or the system font #2

Merged
merged 1 commit into from Jan 4, 2013

Conversation

Projects
None yet
3 participants
Contributor

danielctull commented Jan 4, 2013

Use Menlo if the user doesn't have Inconsolata installed. Use the system font if Menlo is not found.

Owner

aaronvegh commented Jan 4, 2013

I haven't had a chance to look at your code, but do you realize that Inconsolata is bundled with the application? It shouldn't matter whether it's installed on your system (in fact, it likely isn't).

I concur with Daniel - it doesn't work without changing the default font to something other than Inconsolata (for me). I tried something similar to Daniel - just falling back to systemFontOfSize: and I was able to use the app... Just my $0.02

Contributor

danielctull commented Jan 4, 2013

Ah, I didn't see that, but for me it is not getting used.

aaronvegh added a commit that referenced this pull request Jan 4, 2013

Merge pull request #2 from danielctull-forks/master
Fix missing fonts by falling back to Menlo or the system font

@aaronvegh aaronvegh merged commit 05c1bab into aaronvegh:master Jan 4, 2013

Owner

aaronvegh commented Jan 4, 2013

I can't explain the fact that Inconsolata isn't working for you guys, but the code you've added looks like a safe route to take. I've merged it in. Thanks so much for your time with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment