Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tc_gen.py #117

Open
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@TanmayAmbadkar
Copy link

commented Jun 4, 2019

Done the windows stuff first, then the linux and mac stuff, plese review

Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you successfully ran tests with your changes locally?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved

Added windows support
Fixes #{113}

Update tc_gen.py
Done the windows stuff first, then the linux and mac stuff, plese review
@TanmayAmbadkar

This comment has been minimized.

Copy link
Author

commented Jun 12, 2019

I have made the required changes, please review

@aashutoshrathi
Copy link
Owner

left a comment

Please look into comment real quick.

if os.system(LANGS[choice - 1]['compile']) == 0:
zip_them(test_files, choice)

if platform.system()=='Windows':

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Jun 12, 2019

Owner

Why we added if and else conditions here

os.system('%s < input/input%02d.txt > output/output%02d.txt' %
(LANGS[choice - 1]['command'], i, i))

if platform.system()=='Windows':

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Jun 12, 2019

Owner

We could have just compared the first letter, also have you tested it.
Is it Windows or windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.