implemented registration and login for the user #94

mark-nakachon · 2019-05-02T01:56:31Z

Checklist:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you successfully ran tests with your changes locally?
Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved

Now user can be able to log in and signup
Fixes #{90}

mark-nakachon · 2019-05-02T01:56:58Z

please review this and merge this pr

mark-nakachon · 2019-05-03T06:45:40Z

Please review and merge this PR make it fast please, I have other issues to resolve

aashutoshrathi

We are reviewing and things take time, try to be less impulsive.
I understand that you are new, but its time that you understand how FOSS works.

rossoskull

Please look at the inline comment.

rossoskull · 2019-05-03T14:58:58Z

server/index.js

+		bcrypt.hash(newUser.password, salt, (err, hash) => {
+			newUser.password = hash;
+			newUser
+				.save()


Before saving the account here, you should verify it once in the backend too. Add a regex check for email, and checks for the password too. Also, intimate the user with any errors that come forward.

Woking on it

mark-nakachon · 2019-05-04T16:23:08Z

Added form validation please review this. Please make it fast it had been so long I made this PR and gssoc is also coming to end, I have to make more of these

aashutoshrathi

Remove duplicates from Nav
Link login to Login button in Nav
Make form responsive, maybe in a card.

mark-nakachon · 2019-05-08T19:27:27Z

Added changes requested by you now please merge this

rossoskull

Looks good, just take care of the inline comments 🎉

views/pages/signup.ejs

views/pages/login.ejs

mark-nakachon · 2019-05-09T09:21:13Z

Fixed the issues

aashutoshrathi

Please add common Nav and Footer to both upload and login page.
Redirect the nav logo to the valid homepage.
Follow the same theme in both the pages you created.
Please use the center's 50% for forms.

mark-nakachon · 2019-05-09T17:24:53Z

@aashutoshrathi fixed issues requested by you

aashutoshrathi · 2019-05-09T17:56:15Z

Merging this, for now, make sure you do another PR for improving form UI.

@rossoskull Update this in the scoresheet.

mark-nakachon · 2019-05-09T17:58:35Z

Sure I will do this is just only prototyping don't bother about UI I will fix it later

* HackerEarth Added (#63) * hackerearth added * hackerearth * checker.py edited * input folder deleted * folders merged * Add new demo file in dev branch (#64) * Add new demo file * HackerEarth Added (#63) * hackerearth added * hackerearth * checker.py edited * input folder deleted * folders merged * Testcase generator for CodeChef #53 (#66) * Add new demo file (#58) * TestCase generator for CodeChef * ChangedFileNameFormat * Server Initialization (#68) * Add Server Deployment * Move package.json to root * Throw error when unable to execute (#69) * hackerearth added * hackerearth * checker.py edited * input folder deleted * Add new demo file (#58) * folders merged * blank output exception * New line * new line * 🔥 Remove extraspace * ➕ Add Weekly Digest Bot * added a route for file upload * modified changes * added timestamp to resolve conflicts * updated server/index.js * update UI * added a route for solution upload (#73) * added a route for file upload * modified changes * added timestamp to resolve conflicts * updated server/index.js * added changes * deleted uploads folder * made changes to UI * updated the action attribute * UI update (#76) * added a route for file upload * modified changes * added timestamp to resolve conflicts * updated server/index.js * update UI * made changes to UI * updated the action attribute * 🙈 Updated gitignore * Database config (#78) * added cors and headers (#79) * Added a common nav and footer for all pages (#82) * added cors and headers * added header and footer * CHANGED PARTIALS TO COMPONENTS * ☸️ Add newlines at the end of templates * Adding suggested changes - pr from dev to dev (#84) * Adding suggested changes * Adding suggested changes * Added endpoints to all links on homepage (#85) * added cors and headers * added header and footer * CHANGED PARTIALS TO COMPONENTS * added links to all endpoints on homepage * Added a new line at the end of Landin.ejs * Initialized docker environment (#88) * squashed my commits * Initialized Docker Environment * Added new line to Docker file * Added new line * Updated package.json * Updated Dockerfile * Updated README.md * Updated README.md * Made a quick change * Removed question mark * implemented registration and login for the user (#94) * added registration * completed registration * completed login * added form validation * added necessary changes * fixed title * fixed issues * executing scripts as soon as user uploaded file (#95) * executing scripts as soon as user uploaded * fixed issue * Added Protection to all the routes (#101) * squashed my commits * added protection to all routes * Added Logout Route (#100) * executing scripts as soon as user uploaded * fixed issue * user can now download zipped files on server * added logout route * fixed get to post * Added logic and and view to display user files (#102) * squashed commits * added logic and view to display user uploaded files * made changes * Fixed redundant imports * Added a new line at the end * Add Husky and Travis (#105) * set automatic-code-fixing using eslint prettier husky lint-staged editorconfig * Added new line to .editorconfig * Added new line t * Done with this * Added new line * Added new line * added travis * fixed with eslint * fixed error in travis * fixed errors using eslint * Fixed bug in /register route (#111) * squashed my commits * fixed bug in /register route * Added options view * Added a new line for form.ejs * Update lint-staged requirement from ^8.1.7 to ^9.0.2 (#129) Updates the requirements on [lint-staged](https://github.com/okonet/lint-staged) to permit the latest version. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v8.1.7...v9.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update husky requirement from ^2.3.0 to ^3.0.0 (#127) Updates the requirements on [husky](https://github.com/typicode/husky) to permit the latest version. - [Release notes](https://github.com/typicode/husky/releases) - [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md) - [Commits](typicode/husky@v2.3.0...v3.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update express-validator requirement from ^5.3.1 to ^6.1.1 (#126) Updates the requirements on [express-validator](https://github.com/express-validator/express-validator) to permit the latest version. - [Release notes](https://github.com/express-validator/express-validator/releases) - [Commits](express-validator/express-validator@v5.3.1...v6.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update prettier-eslint-cli requirement from ^4.7.1 to ^5.0.0 (#124) Updates the requirements on [prettier-eslint-cli](https://github.com/prettier/prettier-eslint-cli) to permit the latest version. - [Release notes](https://github.com/prettier/prettier-eslint-cli/releases) - [Changelog](https://github.com/prettier/prettier-eslint-cli/blob/master/CHANGELOG.md) - [Commits](prettier/prettier-eslint-cli@v4.7.1...v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Update eslint requirement from ^5.16.0 to ^6.0.1 (#123) Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v5.16.0...v6.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Updates * Update eslint-plugin-node requirement from ^9.0.1 to ^10.0.0 (#135) Updates the requirements on [eslint-plugin-node](https://github.com/mysticatea/eslint-plugin-node) to permit the latest version. - [Release notes](https://github.com/mysticatea/eslint-plugin-node/releases) - [Commits](mysticatea/eslint-plugin-node@v9.0.1...v10.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump prettier-eslint from 8.8.2 to 9.0.1 (#140) Bumps [prettier-eslint](https://github.com/prettier/prettier-eslint) from 8.8.2 to 9.0.1. - [Release notes](https://github.com/prettier/prettier-eslint/releases) - [Changelog](https://github.com/prettier/prettier-eslint/blob/master/CHANGELOG.md) - [Commits](prettier/prettier-eslint@v8.8.2...v9.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

harishchennupati added 3 commits April 30, 2019 22:40

added registration

e654ee3

completed registration

6bb35d3

completed login

5ca531c

aashutoshrathi added the under-review label May 2, 2019

aashutoshrathi requested a review from rossoskull May 2, 2019 10:31

aashutoshrathi requested changes May 3, 2019

View reviewed changes

rossoskull suggested changes May 3, 2019

View reviewed changes

added form validation

d8283da

aashutoshrathi requested review from rossoskull and aashutoshrathi May 4, 2019 17:19

aashutoshrathi requested changes May 8, 2019

View reviewed changes

added necessary changes

8ef6973

rossoskull reviewed May 9, 2019

View reviewed changes

views/pages/signup.ejs Outdated Show resolved Hide resolved

views/pages/login.ejs Outdated Show resolved Hide resolved

fixed title

188e4fa

aashutoshrathi requested changes May 9, 2019

View reviewed changes

fixed issues

5896e7b

aashutoshrathi merged commit 68f9e9f into aashutoshrathi:dev May 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implemented registration and login for the user #94

implemented registration and login for the user #94

mark-nakachon commented May 2, 2019 •

edited

Loading

mark-nakachon commented May 2, 2019

mark-nakachon commented May 3, 2019 •

edited

Loading

aashutoshrathi left a comment

rossoskull left a comment

rossoskull May 3, 2019

mark-nakachon May 4, 2019

mark-nakachon commented May 4, 2019 •

edited

Loading

aashutoshrathi left a comment

mark-nakachon commented May 8, 2019

rossoskull left a comment

mark-nakachon commented May 9, 2019

aashutoshrathi left a comment

mark-nakachon commented May 9, 2019

aashutoshrathi commented May 9, 2019

mark-nakachon commented May 9, 2019

implemented registration and login for the user #94

implemented registration and login for the user #94

Conversation

mark-nakachon commented May 2, 2019 • edited Loading

Checklist:

Issues Solved

mark-nakachon commented May 2, 2019

mark-nakachon commented May 3, 2019 • edited Loading

aashutoshrathi left a comment

Choose a reason for hiding this comment

rossoskull left a comment

Choose a reason for hiding this comment

rossoskull May 3, 2019

Choose a reason for hiding this comment

mark-nakachon May 4, 2019

Choose a reason for hiding this comment

mark-nakachon commented May 4, 2019 • edited Loading

aashutoshrathi left a comment

Choose a reason for hiding this comment

mark-nakachon commented May 8, 2019

rossoskull left a comment

Choose a reason for hiding this comment

mark-nakachon commented May 9, 2019

aashutoshrathi left a comment

Choose a reason for hiding this comment

mark-nakachon commented May 9, 2019

aashutoshrathi commented May 9, 2019

mark-nakachon commented May 9, 2019

mark-nakachon commented May 2, 2019 •

edited

Loading

mark-nakachon commented May 3, 2019 •

edited

Loading

mark-nakachon commented May 4, 2019 •

edited

Loading