handle AASM::InvalidTransition in RSpec transition_from matcher
#653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This properly returns false vs raising an AASM::InvalidTransition error when running specs.
|
Code Climate has analyzed commit 9746cc4 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 95.17% 95.18% +<.01%
==========================================
Files 35 35
Lines 1224 1226 +2
==========================================
+ Hits 1165 1167 +2
Misses 59 59
Continue to review full report at Codecov.
|
|
Thanks for contributing @ryanwood |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
transition_fromRSpec matcher, it returns false when the "from" state is valid but raises an exception when the "from" state is not valid. This commit aligns the two paths so the matcher will return false in both scenarios.