diff --git a/YamlDotNet.Test/Serialization/BufferedDeserialization/KeyValueTypeDiscriminatorTests.cs b/YamlDotNet.Test/Serialization/BufferedDeserialization/KeyValueTypeDiscriminatorTests.cs index f569a470..8a75cdc6 100644 --- a/YamlDotNet.Test/Serialization/BufferedDeserialization/KeyValueTypeDiscriminatorTests.cs +++ b/YamlDotNet.Test/Serialization/BufferedDeserialization/KeyValueTypeDiscriminatorTests.cs @@ -16,7 +16,7 @@ public void KeyValueTypeDiscriminator_WithParentBaseType_Single() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() @@ -38,7 +38,7 @@ public void KeyValueTypeDiscriminator_WithParentBaseType_List() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() @@ -61,7 +61,7 @@ public void KeyValueTypeDiscriminator_WithObjectBaseType_Single() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() @@ -83,7 +83,7 @@ public void KeyValueTypeDiscriminator_WithObjectBaseType_List() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() @@ -106,7 +106,7 @@ public void KeyValueTypeDiscriminator_WithInterfaceBaseType_Single() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() @@ -128,7 +128,7 @@ public void KeyValueTypeDiscriminator_WithInterfaceBaseType_List() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator( "kind", new Dictionary() diff --git a/YamlDotNet.Test/Serialization/BufferedDeserialization/BufferedNodeDeserializerTests.cs b/YamlDotNet.Test/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerTests.cs similarity index 85% rename from YamlDotNet.Test/Serialization/BufferedDeserialization/BufferedNodeDeserializerTests.cs rename to YamlDotNet.Test/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerTests.cs index a13a439e..0a8c8073 100644 --- a/YamlDotNet.Test/Serialization/BufferedDeserialization/BufferedNodeDeserializerTests.cs +++ b/YamlDotNet.Test/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerTests.cs @@ -9,14 +9,14 @@ namespace YamlDotNet.Test.Serialization.BufferedDeserialization { - public class BufferedNodeDeserializerTests + public class TypeDiscriminatingNodeDeserializerTests { [Fact] - public void BufferedNodeDeserializer_ThrowsWhen_MaxDepthExceeded() + public void TypeDiscriminatingNodeDeserializer_ThrowsWhen_MaxDepthExceeded() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator("kind", new Dictionary()); }, maxDepth: 2, @@ -32,11 +32,11 @@ public void BufferedNodeDeserializer_ThrowsWhen_MaxDepthExceeded() } [Fact] - public void BufferedNodeDeserializer_ThrowsWhen_MaxLengthExceeded() + public void TypeDiscriminatingNodeDeserializer_ThrowsWhen_MaxLengthExceeded() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddKeyValueTypeDiscriminator("kind", new Dictionary()); }, maxDepth: 3, diff --git a/YamlDotNet.Test/Serialization/BufferedDeserialization/UniqueKeyTypeDiscriminatorTests.cs b/YamlDotNet.Test/Serialization/BufferedDeserialization/UniqueKeyTypeDiscriminatorTests.cs index 2b7449e1..61a00892 100644 --- a/YamlDotNet.Test/Serialization/BufferedDeserialization/UniqueKeyTypeDiscriminatorTests.cs +++ b/YamlDotNet.Test/Serialization/BufferedDeserialization/UniqueKeyTypeDiscriminatorTests.cs @@ -16,7 +16,7 @@ public void UniqueKeyTypeDiscriminator_WithInterfaceBaseType() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddUniqueKeyTypeDiscriminator( new Dictionary() { @@ -39,7 +39,7 @@ public void UniqueKeyTypeDiscriminator_WithObjectBaseType() { var bufferedDeserializer = new DeserializerBuilder() .WithNamingConvention(CamelCaseNamingConvention.Instance) - .WithBufferedNodeDeserializer(options => { + .WithTypeDiscriminatingNodeDeserializer(options => { options.AddUniqueKeyTypeDiscriminator( new Dictionary() { diff --git a/YamlDotNet/Serialization/BufferedDeserialization/IBufferedNodeDerserializerOptions.cs b/YamlDotNet/Serialization/BufferedDeserialization/ITypeDiscriminatingNodeDeserializerOptions.cs similarity index 94% rename from YamlDotNet/Serialization/BufferedDeserialization/IBufferedNodeDerserializerOptions.cs rename to YamlDotNet/Serialization/BufferedDeserialization/ITypeDiscriminatingNodeDeserializerOptions.cs index dea66d9d..5c545d18 100644 --- a/YamlDotNet/Serialization/BufferedDeserialization/IBufferedNodeDerserializerOptions.cs +++ b/YamlDotNet/Serialization/BufferedDeserialization/ITypeDiscriminatingNodeDeserializerOptions.cs @@ -8,7 +8,7 @@ namespace YamlDotNet.Serialization.BufferedDeserialization { - public interface IBufferedNodeDeserializerOptions + public interface ITypeDiscriminatingNodeDeserializerOptions { public void AddTypeDiscriminator(ITypeDiscriminator discriminator); public void AddKeyValueTypeDiscriminator(string discriminatorKey, IDictionary valueTypeMapping); diff --git a/YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializer.cs b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializer.cs similarity index 87% rename from YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializer.cs rename to YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializer.cs index 64b6ca26..69ba778b 100644 --- a/YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializer.cs +++ b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializer.cs @@ -10,24 +10,24 @@ namespace YamlDotNet.Serialization.BufferedDeserialization { /// - /// The BufferedNodeDeserializer acts as a psuedo . - /// If any of it's has a matching BaseType, the BufferedNodeDeserializer will + /// The TypeDiscriminatingNodeDeserializer acts as a psuedo . + /// If any of it's has a matching BaseType, the TypeDiscriminatingNodeDeserializer will /// begin buffering the yaml stream. It will then use the matching s to determine /// a dotnet output type for the yaml node. As the node is buffered, the s are /// able to examine the actual values within, and use these when discriminating a type. - /// Once a matching type is found, the BufferedNodeDeserializer uses it's inner deserializers to perform + /// Once a matching type is found, the TypeDiscriminatingNodeDeserializer uses it's inner deserializers to perform /// the final deserialization for that type & object. /// Usually you will want all default s that exist in the outer /// to also be used as inner deserializers. /// - public class BufferedNodeDeserializer : INodeDeserializer + public class TypeDiscriminatingNodeDeserializer : INodeDeserializer { private readonly IList innerDeserializers; private readonly IList typeDiscriminators; private readonly int maxDepthToBuffer; private readonly int maxLengthToBuffer; - public BufferedNodeDeserializer(IList innerDeserializers, IList typeDiscriminators, int maxDepthToBuffer, int maxLengthToBuffer) + public TypeDiscriminatingNodeDeserializer(IList innerDeserializers, IList typeDiscriminators, int maxDepthToBuffer, int maxLengthToBuffer) { this.innerDeserializers = innerDeserializers; this.typeDiscriminators = typeDiscriminators; diff --git a/YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializerOptions.cs b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerOptions.cs similarity index 89% rename from YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializerOptions.cs rename to YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerOptions.cs index dddd55a1..0173668c 100644 --- a/YamlDotNet/Serialization/BufferedDeserialization/BufferedNodeDeserializerOptions.cs +++ b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminatingNodeDeserializerOptions.cs @@ -7,12 +7,12 @@ namespace YamlDotNet.Serialization.BufferedDeserialization { - public class BufferedNodeDeserializerOptions : IBufferedNodeDeserializerOptions + public class TypeDiscriminatingNodeDeserializerOptions : ITypeDiscriminatingNodeDeserializerOptions { internal readonly List discriminators = new List(); /// - /// Adds an to be checked by the BufferedNodeDeserializer. + /// Adds an to be checked by the TypeDiscriminatingNodeDeserializer. /// /// The to add. public void AddTypeDiscriminator(ITypeDiscriminator discriminator) @@ -21,7 +21,7 @@ public void AddTypeDiscriminator(ITypeDiscriminator discriminator) } /// - /// Adds a to be checked by the BufferedNodeDeserializer. + /// Adds a to be checked by the TypeDiscriminatingNodeDeserializer. /// s use the value of a specified key on the yaml object to map /// to a target type. /// @@ -33,7 +33,7 @@ public void AddKeyValueTypeDiscriminator(string discriminatorKey, IDictionary } /// - /// Adds a to be checked by the BufferedNodeDeserializer. + /// Adds a to be checked by the TypeDiscriminatingNodeDeserializer. /// s use the presence of unique keys on the yaml object to map /// to different target types. /// diff --git a/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminators/IValueTypeDiscriminator.cs b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminators/IValueTypeDiscriminator.cs index 7e8cb0e1..6d3ad846 100644 --- a/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminators/IValueTypeDiscriminator.cs +++ b/YamlDotNet/Serialization/BufferedDeserialization/TypeDiscriminators/IValueTypeDiscriminator.cs @@ -5,7 +5,7 @@ namespace YamlDotNet.Serialization.BufferedDeserialization.TypeDiscriminators { /// /// An ITypeDiscriminator provides an interface for discriminating which dotnet type to deserialize a yaml - /// stream into. They require the yaml stream to be buffered as they + /// stream into. They require the yaml stream to be buffered as they /// can inspect the yaml value, determine the desired type, and reset the yaml stream to then deserialize into /// that type. /// diff --git a/YamlDotNet/Serialization/DeserializerBuilder.cs b/YamlDotNet/Serialization/DeserializerBuilder.cs index df96c3b3..65b31c68 100755 --- a/YamlDotNet/Serialization/DeserializerBuilder.cs +++ b/YamlDotNet/Serialization/DeserializerBuilder.cs @@ -248,25 +248,25 @@ public DeserializerBuilder WithoutNodeDeserializer(Type nodeDeserializerType) } /// - /// Registers a to be used by the deserializer. This internally registers - /// all existing as inner deserializers available to the . + /// Registers a to be used by the deserializer. This internally registers + /// all existing as inner deserializers available to the . /// Usually you will want to call this after any other changes to the s used by the deserializer. /// - /// An action that can configure the . + /// An action that can configure the . /// Configures the max depth of yaml nodes that will be buffered. A value of -1 (the default) means yaml nodes of any depth will be buffered. /// Configures the max number of yaml nodes that will be buffered. A value of -1 (the default) means there is no limit on the number of yaml nodes buffered. - public DeserializerBuilder WithBufferedNodeDeserializer( - Action configureBufferedNodeDeserializerOptions, int maxDepth = -1, int maxLength = -1) + public DeserializerBuilder WithTypeDiscriminatingNodeDeserializer( + Action configureTypeDiscriminatingNodeDeserializerOptions, int maxDepth = -1, int maxLength = -1) { - var options = new BufferedNodeDeserializerOptions(); - configureBufferedNodeDeserializerOptions(options); - // We use all current NodeDeserializers as the inner deserializers for the BufferedNodeDeserializer, + var options = new TypeDiscriminatingNodeDeserializerOptions(); + configureTypeDiscriminatingNodeDeserializerOptions(options); + // We use all current NodeDeserializers as the inner deserializers for the TypeDiscriminatingNodeDeserializer, // so that it can successfully deserialize anything our root deserializer can. - var bufferedNodeDeserializer = new BufferedNodeDeserializer(nodeDeserializerFactories.BuildComponentList(), options.discriminators, maxDepth, maxLength); + var TypeDiscriminatingNodeDeserializer = new TypeDiscriminatingNodeDeserializer(nodeDeserializerFactories.BuildComponentList(), options.discriminators, maxDepth, maxLength); // We register this before the DictionaryNodeDeserializer, as otherwise it will take precedence - // and cases where BaseType = object will not reach the BufferedNodeDeserializer - return WithNodeDeserializer(bufferedNodeDeserializer, s => s.Before()); + // and cases where BaseType = object will not reach the TypeDiscriminatingNodeDeserializer + return WithNodeDeserializer(TypeDiscriminatingNodeDeserializer, s => s.Before()); } /// diff --git a/YamlDotNet/Serialization/StaticDeserializerBuilder.cs b/YamlDotNet/Serialization/StaticDeserializerBuilder.cs index 09540263..86fa1691 100644 --- a/YamlDotNet/Serialization/StaticDeserializerBuilder.cs +++ b/YamlDotNet/Serialization/StaticDeserializerBuilder.cs @@ -207,25 +207,25 @@ public StaticDeserializerBuilder WithoutNodeDeserializer(Type nodeDeserializerTy } /// - /// Registers a to be used by the deserializer. This internally registers - /// all existing as inner deserializers available to the . + /// Registers a to be used by the deserializer. This internally registers + /// all existing as inner deserializers available to the . /// Usually you will want to call this after any other changes to the s used by the deserializer. /// - /// An action that can configure the . + /// An action that can configure the . /// Configures the max depth of yaml nodes that will be buffered. A value of -1 (the default) means yaml nodes of any depth will be buffered. /// Configures the max number of yaml nodes that will be buffered. A value of -1 (the default) means there is no limit on the number of yaml nodes buffered. - public StaticDeserializerBuilder WithBufferedNodeDeserializer( - Action configureBufferedNodeDeserializerOptions, int maxDepth = -1, int maxLength = -1) + public StaticDeserializerBuilder WithTypeDiscriminatingNodeDeserializer( + Action configureTypeDiscriminatingNodeDeserializerOptions, int maxDepth = -1, int maxLength = -1) { - var options = new BufferedNodeDeserializerOptions(); - configureBufferedNodeDeserializerOptions(options); - // We use all current NodeDeserializers as the inner deserializers for the BufferedNodeDeserializer, + var options = new TypeDiscriminatingNodeDeserializerOptions(); + configureTypeDiscriminatingNodeDeserializerOptions(options); + // We use all current NodeDeserializers as the inner deserializers for the TypeDiscriminatingNodeDeserializer, // so that it can successfully deserialize anything our root deserializer can. - var bufferedNodeDeserializer = new BufferedNodeDeserializer(nodeDeserializerFactories.BuildComponentList(), options.discriminators, maxDepth, maxLength); + var TypeDiscriminatingNodeDeserializer = new TypeDiscriminatingNodeDeserializer(nodeDeserializerFactories.BuildComponentList(), options.discriminators, maxDepth, maxLength); // We register this before the DictionaryNodeDeserializer, as otherwise it will take precedence - // and cases where BaseType = object will not reach the BufferedNodeDeserializer - return WithNodeDeserializer(bufferedNodeDeserializer, s => s.Before()); + // and cases where BaseType = object will not reach the TypeDiscriminatingNodeDeserializer + return WithNodeDeserializer(TypeDiscriminatingNodeDeserializer, s => s.Before()); } ///