Aymeric Augustin aaugustin

Organizations

@django @oscaro
aaugustin commented on pull request django/django#4742
@aaugustin

Could you add a test for this in tests/utils_tests/test_model_loading? Anything that fails without your change and works with your change will do.

aaugustin commented on pull request django/django#4736
@aaugustin

Perhaps we should also add this flag to deprecation.txt?

@aaugustin

I have no idea. Try it and let me know? :-)

aaugustin commented on issue aaugustin/websockets#56
@aaugustin

Each websocket connection runs an asyncio task that handles automatically control frames (ping, pong, close). If something goes wrong, the task can…

aaugustin commented on pull request django/django#4712
@aaugustin

This looks good to me.

aaugustin commented on pull request aaugustin/websockets#55
@aaugustin

Do you think I should add a wait_close() method?

aaugustin commented on pull request django/django#4698
@aaugustin

It may be more robust to use: elif isinstance(lhs_output_field, TimeField): ... else: raise ValueError(...)

aaugustin commented on pull request django/django#4657
@aaugustin

Great job!

@aaugustin

The code that handles this is here: https://github.com/trac-hacks/trac-github/blob/master/tracext/github.py#L24-L34 and the configuration is there: h…

aaugustin commented on pull request django/django#4657
@aaugustin

No objection.

aaugustin commented on pull request django/django#4657
@aaugustin

This idea was previously discussed in https://code.djangoproject.com/ticket/17085. @prestontimmons Could you read that ticket and make sure it does…

aaugustin commented on pull request django/django#4657
@aaugustin

This paragraph needs a .. versionadded: directive.

aaugustin commented on pull request django/django#4673
@aaugustin

One of the original design goals of the Django Template Language was to be usable by non-programmers. Perhaps we could have a discussion on whether…

aaugustin commented on pull request django/django#4672
@aaugustin

Yes.

aaugustin commented on pull request django/django#4657
@aaugustin

I don't remember anything in particular, I just refactored incrementally and ended up there.

aaugustin commented on pull request django/django#4657
@aaugustin

Scratch that, the public API is django.template.Library, not django.template.base.Library

aaugustin commented on pull request django/django#4657
@aaugustin

We have a small inconsistency here. Loaders are imported and initialized when the first template is loaded (through a cached property). Builtins an…

aaugustin commented on pull request django/django#4657
@aaugustin

Likewise.

aaugustin commented on pull request django/django#4657
@aaugustin

Is there a reason for dealing with builtins here? Otherwise, can you keep the order of parameters consistent by moving this just after libraries?

aaugustin commented on pull request django/django#4657
@aaugustin

Lots of people call add_to_builtins to register their own template tags globally. While it is technically not a public API, you should say somethin…

aaugustin commented on pull request django/django#4657
@aaugustin

Library is a public API. In order to move it, you must include a dummy subclass whose __init__ raises a deprecation warning. See django.contrib.gis…

aaugustin commented on pull request django/django#4657
@aaugustin

If I understand correctly, there's no way to reach this view through the admindocs UI when Engine.get_default() raises ImproperlyConfigured, so you…

@aaugustin
aaugustin commented on pull request django/django#4601
@aaugustin

Thanks a lot @carljm and @timgraham for your help!

@aaugustin
aaugustin merged pull request django/django#4601
@aaugustin
Refactor adaptation and conversion of aware datetimes
9 commits with 545 additions and 273 deletions
@aaugustin
@aaugustin
@aaugustin

OK.

@aaugustin
Support for multiple template engines