This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Borrow/repay check removal#705
Merged
Merged
Conversation
The-3D
requested review from
Zer0dot,
bensprks,
donosonaumczuk,
foodaka,
kartojal,
miguelmtzinf and
stevenvaleri
as code owners
miguelmtzinf
suggested changes
Aug 9, 2022
| ).to.be.revertedWith(RESERVE_INACTIVE); | ||
| }); | ||
|
|
||
| it('validateRepay() when variable borrowing and repaying in same block (revert expected)', async () => { |
Member
There was a problem hiding this comment.
I believe its better to add these tests cases as non-reverting
miguelmtzinf
approved these changes
Aug 9, 2022
Collaborator
|
looks fine |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.