Skip to content

Conversation

@foodaka
Copy link
Collaborator

@foodaka foodaka commented Apr 6, 2025

General Changes

  • Bumps address book and fixes voting machine

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 10:08am
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 10:08am

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 914.26 KB (🟡 +454 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

@github-actions
Copy link

github-actions bot commented Apr 7, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 914.29 KB (🟡 +490 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@foodaka foodaka changed the title chore: bump address book chore: bump address book [skip cypress] Apr 7, 2025
@CanonicalJP CanonicalJP self-requested a review April 7, 2025 13:32
@foodaka foodaka merged commit 911ca50 into main Apr 7, 2025
31 of 32 checks passed
@foodaka foodaka deleted the fix/voting-machine branch April 7, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants