Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1 Added startup message #5

Merged
merged 1 commit into from May 10, 2020
Merged

Fixes #1 Added startup message #5

merged 1 commit into from May 10, 2020

Conversation

muhammednagy
Copy link
Member

@muhammednagy muhammednagy commented May 9, 2020 •
edited

Changes proposed in this pull request:

  • Added startup message

@auto-assign auto-assign bot requested a review from abahmed May 9, 2020 12:37
@abahmed
Copy link
Member

abahmed commented May 9, 2020 •
edited

@muhammednagy Please use our PR template (e.g. Fixes #1 )

Fixes #ISSUE_NUMBER

abahmed
abahmed requested changes May 9, 2020
View reviewed changes
Copy link
Member

@abahmed abahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to print also Gearbox name and version

@muhammednagy muhammednagy changed the title #1 Added startup message Fixes #1 Added startup message May 10, 2020
@muhammednagy muhammednagy requested a review from abahmed May 10, 2020 21:08
@muhammednagy muhammednagy merged commit 71e1f79 into master May 10, 2020
@abahmed abahmed added the enhancement New feature or request label May 10, 2020
@abahmed abahmed added this to In Progress in Gearbox via automation May 10, 2020
@abahmed abahmed added this to the v1 milestone May 10, 2020
@muhammednagy muhammednagy moved this from In Progress to Done in Gearbox May 10, 2020
@abahmed abahmed deleted the feature/add-startup-message branch May 11, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abahmed abahmed Awaiting requested review from abahmed

Assignees

@abahmed abahmed

Labels
enhancement New feature or request
Projects
Gearbox
  
Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@muhammednagy @abahmed