Binding options #121
Binding options #121
Conversation
allow ```option.deviceId``` to be int 0. previous check returned false and falled back to ENV configuration
|
please rebase |
Node-10 to be then supported Origin: noble@e2c476e Forwarded: noble#851 Change-Id: I3c20732e71456cbe2b33509ccf2e0b72ca75442f Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I84415cf2fe5f450fd6aab3429ea14c4cb816cb91 Origin: abandonware#1 Forwarded: noble#851 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Might be obsolete and it does not worth to keep maintaining it Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600 Change-Id: I04be1fa73626402bb81775b056cabde32ced0960 Origin: abandonware#1 Forwarded: noble#851 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I661e9105c313179526fe43585b78cf1156e1f0d9 Origin: abandonware#1 Forwarded: noble#851 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Abandonware namespace was used Update bluetooth-hci-socket for node-10 Relate-to: noble/node-bluetooth-hci-socket#84 Origin: abandonware#1 Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb Origin: abandonware#1 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Origin: abandonware#1 Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Not all bindings support addService or addCharacteristics
remove whitespace
bitcloud
force-pushed
the
binding_options
branch
from
c2fb75e
to
64b9744
Compare
|
this PR needs to be rebased, or you can submit smaller changes |
|
I startet it already, but it needs more effort then I originally thought and I currently have very little spare time at hand. So this is gonna take some time.
If someone else wants to jump in, feel free.
… On 5. Oct 2020, at 13:49, Philippe Coval ***@***.***> wrote:
this PR needs to be rebased, or you can submit smaller changes
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACYW6OJ6WV6NXLTMU25TTDSJGXDBANCNFSM4RNCOJ3Q>.
|
|
Would it make sense that we close this PR, you can split this changeset into several smaller PR ? |
|
may you try to split your changes in smaller PRs |
|
can this change be part of next release ? |
|
@rzr this change (at least as it is described in the post) was merged in #155 and released in v1.9.2-12. The diff for this PR is quite large, and contains other, unrelated changes. @atrovato has pulled out out other features (see #174) and the rest is left in #185. I believe this PR can be rejected/closed. Disclaimer: I'm just a user of this library (thanks for keeping it maintained!) |
|
Ok please rebase to see if there are any leftover |
|
ping |
|
This branch has conflicts that must be resolved |
|
release is planned soon do you want this change to be part of it ? |
|
ping |
|
Is anyone interested to take over this change ? |
|
@bitcloud Ping! |
|
I assume there is no interest, feel free to cherrypick change an open a new PR |
transfer from noble#651
To use two different devices in one setup you need to configure the binding in your code and not with ENV-Vars.
I am using one device for connecting while the other keeps on collecting advertisements.