Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed and Jquery 3 #1117

Closed
BasaraABC opened this issue Apr 19, 2018 · 6 comments

Comments

@BasaraABC
Copy link
Collaborator

commented Apr 19, 2018

Embed is not work if web site use jQuery 3
TypeError: a.indexOf is not a function
Forum post http://forum.abantecart.com/index.php/topic,6516.msg27466.html#msg27466
See if this help you to fix https://stackoverflow.com/questions/38871753/uncaught-typeerror-a-indexof-is-not-a-function-error-when-opening-new-foundat

Also check this guide maybe we can upgrade to 3.0 https://jquery.com/upgrade-guide/3.0/#jquery-migrate-plugin

@BasaraABC BasaraABC added the Embed label Apr 19, 2018

@BasaraABC BasaraABC added this to the 1.2.13 milestone Apr 19, 2018

@Luxinbag

This comment has been minimized.

Copy link

commented Apr 19, 2018

Hi all,
First, thanks for your work !
When do you think this update 1.2.13 come in ?
Thanks in advance.
Franck

@abantecart

This comment has been minimized.

Copy link
Owner

commented Apr 19, 2018

@Luxinbag

This comment has been minimized.

Copy link

commented Apr 19, 2018

Thanks, and is there a beta version?
I don't have to use it in production since may 1 but it permit to work and test before ;-) and I don't know how to downgrade the jquery version!
thanks
Franck

@Luxinbag

This comment has been minimized.

Copy link

commented Apr 29, 2018

Hi all,
Someone know when the v.1.2.13 will be released ?
Thanks in advance.
Franck

@abantecart

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2018

We postpone for 2 more weeks. Few issues left and we wait on some partner as well.

@abantecart abantecart removed the discussion label Jul 5, 2018

@abolabo

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2018

not an AbanteCart bug. It's jquery compatibility issue.
To solve just place <script src="https://code.jquery.com/jquery-migrate-3.0.1.js"></script> before embed code on your page.

@abolabo abolabo added the Won't Fix label Aug 10, 2018

@BasaraABC BasaraABC closed this Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.