From 0baf96e37ce3673c5ed330af5a0e39cb3bee4b03 Mon Sep 17 00:00:00 2001 From: larshp Date: Sun, 19 Apr 2020 10:08:51 +0200 Subject: [PATCH] remove tabs, remove seq empty lines --- abaplint.json | 31 ++++++++++++++------ src/zcl_excel_reader_2007.clas.abap | 3 -- src/zcl_excel_worksheet.clas.abap | 2 +- src/zcl_excel_worksheet_pagebreaks.clas.abap | 2 +- src/zcl_excel_writer_2007.clas.abap | 6 ---- src/zdemo_excel11.prog.abap | 6 ++-- src/zdemo_excel13.prog.abap | 3 -- src/zdemo_excel16.prog.abap | 3 -- src/zdemo_excel17.prog.abap | 3 -- src/zdemo_excel18.prog.abap | 3 -- src/zdemo_excel26.prog.abap | 4 +-- src/zdemo_excel30.prog.abap | 3 -- src/zdemo_excel32.prog.abap | 4 +-- src/zdemo_excel39.prog.abap | 6 ---- src/zdemo_excel40.prog.abap | 3 -- src/zdemo_excel_outputopt_incl.prog.abap | 3 -- 16 files changed, 31 insertions(+), 54 deletions(-) diff --git a/abaplint.json b/abaplint.json index b6da1f4a3..7e8ebbfaf 100644 --- a/abaplint.json +++ b/abaplint.json @@ -7,19 +7,32 @@ }, "dependencies": [], "syntax": { - "version": "v700", + "version": "v702", "errorNamespace": "^(Z|Y)", "globalConstants": [], "globalMacros": [] }, "rules": { + "forbidden_identifier": false, + "try_without_catch": true, + "unknown_types": false, "prefix_is_current_class": false, "unused_variables": false, "abapdoc": false, "allowed_object_naming": true, "allowed_object_types": false, "ambiguous_statement": false, - "avoid_use": false, + "avoid_use": { + "define": false, + "endselect": false, + "execSQL": true, + "kernelCall": true, + "communication": true, + "statics": false, + "systemCall": true, + "defaultKey": false, + "break": true + }, "begin_end_names": true, "chain_mainly_declarations": false, "check_abstract": true, @@ -31,15 +44,15 @@ "check_text_elements": false, "check_transformation_exists": true, "commented_code": false, - "constructor_visibility_public": false, - "description_empty": false, + "constructor_visibility_public": true, + "description_empty": true, "double_space": false, "empty_line_in_statement": false, "empty_structure": false, "form_no_dash": true, "form_tables_obsolete": true, "fully_type_constants": false, - "global_class": false, + "global_class": true, "identical_form_names": true, "if_in_if": false, "implement_methods": false, @@ -59,7 +72,7 @@ "preferred_compare_operator": false, "release_idoc": false, "remove_descriptions": false, - "rfc_error_handling": false, + "rfc_error_handling": true, "selection_screen_naming": false, "short_case": false, "sicf_consistency": true, @@ -68,14 +81,14 @@ "superclass_final": false, "tabl_enhancement_category": false, "type_begin_single_include": true, - "type_form_parameters": false, + "type_form_parameters": true, "types_naming": false, "unreachable_code": true, "use_new": false, "when_others_last": true, "xml_consistency": true, "7bit_ascii": false, - "contains_tab": false, + "contains_tab": true, "functional_writing": false, "line_length": false, "max_one_statement": false, @@ -89,7 +102,7 @@ "whitespace_end": true, "exporting": false, "empty_statement": false, - "sequential_blank": false, + "sequential_blank": true, "definitions_top": false, "nesting": false, "cloud_types": true, diff --git a/src/zcl_excel_reader_2007.clas.abap b/src/zcl_excel_reader_2007.clas.abap index 65c73db0d..b985f1e1d 100644 --- a/src/zcl_excel_reader_2007.clas.abap +++ b/src/zcl_excel_reader_2007.clas.abap @@ -565,9 +565,6 @@ METHOD get_dxf_style_guid. ENDWHILE. - - - rv_style_guid = io_excel->get_static_cellstyle_guid( ip_cstyle_complete = ls_cstyle ip_cstylex_complete = ls_cstylex ). diff --git a/src/zcl_excel_worksheet.clas.abap b/src/zcl_excel_worksheet.clas.abap index 72b88059e..1d48a402d 100644 --- a/src/zcl_excel_worksheet.clas.abap +++ b/src/zcl_excel_worksheet.clas.abap @@ -5411,7 +5411,7 @@ CLASS ZCL_EXCEL_WORKSHEET IMPLEMENTATION. *--------------------------------------------------------------------* * Check whether title consists only of allowed characters -* Illegal characters are: / \ [ ] * ? : --> http://msdn.microsoft.com/en-us/library/ff837411.aspx +* Illegal characters are: / \ [ ] * ? : --> http://msdn.microsoft.com/en-us/library/ff837411.aspx * Illegal characters not in documentation: ' as first character *--------------------------------------------------------------------* IF ip_title CA '/\[]*?:'. diff --git a/src/zcl_excel_worksheet_pagebreaks.clas.abap b/src/zcl_excel_worksheet_pagebreaks.clas.abap index 9a7b2dfbd..dfa0a9255 100644 --- a/src/zcl_excel_worksheet_pagebreaks.clas.abap +++ b/src/zcl_excel_worksheet_pagebreaks.clas.abap @@ -6,7 +6,7 @@ public section. types: BEGIN OF ts_pagebreak_at , - cell_row TYPE zexcel_cell_row, + cell_row TYPE zexcel_cell_row, cell_column TYPE zexcel_cell_column, END OF ts_pagebreak_at . types: diff --git a/src/zcl_excel_writer_2007.clas.abap b/src/zcl_excel_writer_2007.clas.abap index 13d0d9809..04119a750 100644 --- a/src/zcl_excel_writer_2007.clas.abap +++ b/src/zcl_excel_writer_2007.clas.abap @@ -5363,9 +5363,6 @@ METHOD create_xl_sheet_pagebreaks. lo_node_colbreaks->set_attribute( name = 'count' value = lv_value ). lo_node_colbreaks->set_attribute( name = 'manualBreakCount' value = lv_value ). - - - io_parent->append_child( new_child = lo_node_rowbreaks ). io_parent->append_child( new_child = lo_node_colbreaks ). @@ -6516,9 +6513,6 @@ METHOD create_xl_styles. lo_sub_element->append_child( new_child = lo_sub_element_2 ). ENDIF. - - - ELSE. "pattern lo_sub_element = lo_document->create_simple_element( name = lc_xml_node_patternfill diff --git a/src/zdemo_excel11.prog.abap b/src/zdemo_excel11.prog.abap index 645459fae..10dd386bb 100644 --- a/src/zdemo_excel11.prog.abap +++ b/src/zdemo_excel11.prog.abap @@ -202,9 +202,9 @@ START-OF-SELECTION. DATA: lt_field_catalog TYPE zexcel_t_fieldcatalog, ls_table_settings TYPE zexcel_s_table_settings. - DATA: column TYPE zexcel_cell_column, - column_alpha TYPE zexcel_cell_column_alpha, - value TYPE zexcel_cell_value. + DATA: column TYPE zexcel_cell_column, + column_alpha TYPE zexcel_cell_column_alpha, + value TYPE zexcel_cell_value. FIELD-SYMBOLS: TYPE zexcel_s_fieldcatalog. diff --git a/src/zdemo_excel13.prog.abap b/src/zdemo_excel13.prog.abap index 832601783..fa1a085d5 100644 --- a/src/zdemo_excel13.prog.abap +++ b/src/zdemo_excel13.prog.abap @@ -85,8 +85,5 @@ START-OF-SELECTION. lo_worksheet->set_area( ip_row = 21 ip_row_to = 22 ip_column_start = 'B' ip_column_end = 'G' ip_style = lv_style_bold_border_guid ip_value = 'Test area' ). - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel16.prog.abap b/src/zdemo_excel16.prog.abap index d6e61165e..afba621d0 100644 --- a/src/zdemo_excel16.prog.abap +++ b/src/zdemo_excel16.prog.abap @@ -129,8 +129,5 @@ START-OF-SELECTION. lo_worksheet->add_drawing( lo_drawing ). ENDIF. - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel17.prog.abap b/src/zdemo_excel17.prog.abap index 59aabfff5..29fc1260d 100644 --- a/src/zdemo_excel17.prog.abap +++ b/src/zdemo_excel17.prog.abap @@ -49,8 +49,5 @@ START-OF-SELECTION. lo_worksheet->set_cell( ip_row = 7 ip_column = 'C' ip_value = 'This cell is unlocked' ip_style = lv_style_protection_guid ). lo_worksheet->set_cell( ip_row = 8 ip_column = 'C' ip_value = 'This cell is locked as all the others empty cell' ). - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel18.prog.abap b/src/zdemo_excel18.prog.abap index 338ec2de2..e28075dc0 100644 --- a/src/zdemo_excel18.prog.abap +++ b/src/zdemo_excel18.prog.abap @@ -30,8 +30,5 @@ START-OF-SELECTION. lo_worksheet = lo_excel->get_active_worksheet( ). lo_worksheet->set_cell( ip_row = 4 ip_column = 'C' ip_value = 'This cell is unlocked' ip_style = lv_style_protection_guid ). - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel26.prog.abap b/src/zdemo_excel26.prog.abap index ea47c5435..bf40ca17b 100644 --- a/src/zdemo_excel26.prog.abap +++ b/src/zdemo_excel26.prog.abap @@ -158,8 +158,8 @@ endform. "EXPORT_TO_EXCEL * <-- p2 text *----------------------------------------------------------------------* form write_file . - data: lt_file type solix_tab, - l_bytecount type i, + data: lt_file type solix_tab, + l_bytecount type i, l_file type xstring. data: lo_excel_writer type ref to zif_excel_writer. diff --git a/src/zdemo_excel30.prog.abap b/src/zdemo_excel30.prog.abap index bf13f9876..bb078073e 100644 --- a/src/zdemo_excel30.prog.abap +++ b/src/zdemo_excel30.prog.abap @@ -92,8 +92,5 @@ START-OF-SELECTION. lo_column = lo_worksheet->get_column( ip_column = 'E' ). lo_column->set_auto_size( abap_true ). - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel32.prog.abap b/src/zdemo_excel32.prog.abap index 7bdad2677..b1915a59c 100644 --- a/src/zdemo_excel32.prog.abap +++ b/src/zdemo_excel32.prog.abap @@ -194,8 +194,8 @@ ENDFORM. "EXPORT_TO_EXCEL_BIND * <-- p2 text *----------------------------------------------------------------------* FORM write_file . - DATA: lt_file TYPE solix_tab, - l_bytecount TYPE i, + DATA: lt_file TYPE solix_tab, + l_bytecount TYPE i, l_file TYPE xstring. DATA: lo_excel_writer TYPE REF TO zif_excel_writer. diff --git a/src/zdemo_excel39.prog.abap b/src/zdemo_excel39.prog.abap index 57ebaebbb..cc6e1e397 100644 --- a/src/zdemo_excel39.prog.abap +++ b/src/zdemo_excel39.prog.abap @@ -286,12 +286,6 @@ START-OF-SELECTION. * ip_crossbetween = . - - - - - - " Creates active sheet CREATE OBJECT lo_excel. diff --git a/src/zdemo_excel40.prog.abap b/src/zdemo_excel40.prog.abap index a991a8f6e..1d61087b7 100644 --- a/src/zdemo_excel40.prog.abap +++ b/src/zdemo_excel40.prog.abap @@ -76,8 +76,5 @@ START-OF-SELECTION. CATCH zcx_excel . ENDTRY. - - - *** Create output lcl_output=>output( lo_excel ). diff --git a/src/zdemo_excel_outputopt_incl.prog.abap b/src/zdemo_excel_outputopt_incl.prog.abap index b632cc64f..4930d5132 100644 --- a/src/zdemo_excel_outputopt_incl.prog.abap +++ b/src/zdemo_excel_outputopt_incl.prog.abap @@ -246,9 +246,6 @@ CLASS lcl_output IMPLEMENTATION. CLOSE DATASET p_backfn. - - - IF sy-repid <> sy-cprog AND sy-cprog IS NOT INITIAL. " no need to display anything if download was selected and report was called for demo purposes LEAVE PROGRAM. ELSE.