Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #30 /tags should give a list of tags #39

Merged
merged 1 commit into from May 2, 2016
Merged

Conversation

voila
Copy link
Contributor

@voila voila commented Apr 30, 2016

A lot of edits are a result of running ocp-indent, and just change the indentation... I hope that's OK.

@hannesm
Copy link
Collaborator

hannesm commented Apr 30, 2016

cool. would be easier to review if you'd separate the ocp-indent in a separate commit (same PR is fine)

@voila
Copy link
Contributor Author

voila commented Apr 30, 2016

Not sure if this fixed the indentation problem.

I have annotated the relevant changes, in the commit, to make it easier to review.

I am unsure of what I should do re:code formating, in the future... I use Emacs M-x untabify because some files in the master branch have tabs in them, but that also seem to change the indentation. So I used ocp-indent as @Engil suggested, but the resulting indentation is different too, adding a lot of noise to my commits.


let compare a b = Ptime.compare (date b) (date a)

let updated = function
| Markdown m ->
m.Canopy_article.updated

let tags content_map =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new function that returns all existings tags (as string list) from the cache map (populated in Store.fill_cache)

@hannesm
Copy link
Collaborator

hannesm commented May 2, 2016

lgtm

@abbysmal
Copy link
Owner

abbysmal commented May 2, 2016

Everything looks fine to me, tested it just now, looks great! (was a bit busy this week end again, sorry for being late to the party…)
Thank you @hannesm for reviewing everything, and thank you @voila again for delivering such nice PRs…
Merging. :)

@abbysmal abbysmal merged commit 2ad57e6 into abbysmal:master May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants