New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USB_USBTask() depreciated when INTERRUPT_CONTROL_ENDPOINT is enabled #105

Open
NicoHood opened this Issue Dec 2, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@NicoHood
Copy link
Contributor

NicoHood commented Dec 2, 2017

As far as I can see USB_USBTask() manages the control endpoint when it is not handled via interrupts. However if you do use INTERRUPT_CONTROL_ENDPOINT, it is not required and should be removed.

You could then remove the function completely in the lufa source via #ifdef INTERRUPT_CONTROL_ENDPOINT which will result in a compile error. Most users will not know what to do then, why the symbol is missing.

As an alternative you can declare the function as depreciated with a custom text, warning that it is useless when INTERRUPT_CONTROL_ENDPOINT was used.

@NicoHood

This comment has been minimized.

Copy link
Contributor

NicoHood commented Dec 2, 2017

I also notived that the usb task is available in some class drivers. It has to be surrounded by ifdefs too. Example: static int CDC_Device_getchar_Blocking(FILE* Stream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment