New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HID] No error on too big bootloader size #72

Open
NicoHood opened this Issue Feb 14, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@NicoHood
Copy link
Contributor

NicoHood commented Feb 14, 2016

If i try to compile the CDC bootloader with 2kb setting (for 32u4) I get a compile error.
For the HID I dont get a compile error.

It would be nice to a) get an error and b) maybe improve the error, so one know whats going on.

@abcminiuser

This comment has been minimized.

Copy link
Owner

abcminiuser commented Feb 15, 2016

Good idea, added to my backlog. Unfortunately this won't have a nice answer I suspect (given that different parts have different maximum bootloader size restrictions) so it will probably end up being string parsing and a lookup table. Yuck.

@NicoHood

This comment has been minimized.

Copy link
Contributor

NicoHood commented Feb 15, 2016

the bootloader size is in the makefile given. you need to enter it there. If the user adds a wrong value, then it is out of scope. but while developing you should be able to set a limit for yourself and see if you reached it already. Also it is confusing because lufa uses those jump tables. and therefor 96 bytes are missing and calculating it yourself might not be obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment